Update Camera Intrinsics in camera_info topic #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aditya <aditya050995@gmail.com>
8 tasks
7 tasks
|
gz-rendering 7.2.0 release is out, re triggering CI here. |
|
@osrf-jenkins run tests please |
Codecov Report
@@ Coverage Diff @@
## gz-sensors7 #281 +/- ##
===============================================
+ Coverage 69.17% 69.24% +0.07%
===============================================
Files 35 35
Lines 3740 3749 +9
===============================================
+ Hits 2587 2596 +9
Misses 1153 1153
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
8 tasks
iche033
approved these changes
Nov 18, 2022
ahcorde
approved these changes
Nov 21, 2022
ahcorde
pushed a commit
that referenced
this pull request
Sep 13, 2023
Signed-off-by: Aditya <aditya050995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸
🎉 New feature
Summary
A refactor of #265 so that it can be targeted to Gazebo Garden.
This PR solves the camera intrinsics not being reflected properly in /camera_info topic when the tag is not provided. The PR uses the
projectionToCameraIntrinsic()from gz-rendering to get the camera intrinsics and update the sdf DOM object and /camera_info topic.Depends on gazebosim/gz-rendering#755.
Test it
Added a test in
test/integration/camera.cc.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸