Minor cleanup of dartsim #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shameekganguly
commented
Jun 7, 2023
shameekganguly
commented
- Change remaning ignerr to gzerr
- Clangtidy fixes
- Remove unused header
Signed-off-by: Shameek Ganguly <shameekarcanesphinx@gmail.com>
Signed-off-by: Shameek Ganguly <shameekarcanesphinx@gmail.com>
iche033
reviewed
Jun 7, 2023
Signed-off-by: Shameek Ganguly <shameekarcanesphinx@gmail.com>
azeey
reviewed
Jun 13, 2023
dartsim/src/ShapeFeatures.cc
Outdated
| @@ -252,7 +252,7 @@ Vector3d ShapeFeatures::GetEllipsoidShapeRadii( | |||
| Identity ShapeFeatures::AttachEllipsoidShape( | |||
| const Identity &_linkID, | |||
| const std::string &_name, | |||
| const Vector3d _radii, | |||
| const Vector3d &_radii, | |||
There was a problem hiding this comment.
I think this is a breaking change, so we wouldn't want to do it in this branch. Instead, it should go into main. Also, to do this, we'd have to change the signatures in the AttachEllipsoidShapeFeature (https://github.com/gazebosim/gz-physics/blob/8ee8028861567303cdba2602c9ba79c34a5ab542/include/gz/physics/EllipsoidShape.hh)
There was a problem hiding this comment.
I've applied these API changes in #521, targeting main
There was a problem hiding this comment.
I reverted this change in 39e4753
8 tasks
Continue passing Vector3 by value to AttachEllipsoidShape on garden. This has already been changed to pass by const ref on main. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
iche033
approved these changes
Aug 7, 2023
|
Thanks Steve, looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.