Skip to content

Commit

Permalink
Revert changes that change public ABI
Browse files Browse the repository at this point in the history
Continue passing Vector3 by value to
AttachEllipsoidShape on garden. This has
already been changed to pass by const ref on main.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
  • Loading branch information
scpeters committed Aug 7, 2023
1 parent 63e5b55 commit 39e4753
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion dartsim/src/ShapeFeatures.cc
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ Vector3d ShapeFeatures::GetEllipsoidShapeRadii(
Identity ShapeFeatures::AttachEllipsoidShape(
const Identity &_linkID,
const std::string &_name,
const Vector3d &_radii,
const Vector3d _radii,
const Pose3d &_pose)
{
common::MeshManager *meshMgr = common::MeshManager::Instance();
Expand Down
2 changes: 1 addition & 1 deletion dartsim/src/ShapeFeatures.hh
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ class ShapeFeatures :
public: Identity AttachEllipsoidShape(
const Identity &_linkID,
const std::string &_name,
const Vector3d &_radii,
const Vector3d _radii,
const Pose3d &_pose) override;

// ----- Sphere Features -----
Expand Down

0 comments on commit 39e4753

Please sign in to comment.