Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove API sub-module #244

Merged
merged 1 commit into from
Oct 22, 2021
Merged

Remove API sub-module #244

merged 1 commit into from
Oct 22, 2021

Conversation

timuthy
Copy link
Member

@timuthy timuthy commented Oct 21, 2021 •
edited
Loading

How to categorize this PR?

/area dev-productivity
/kind enhancement

What this PR does / why we need it:
This PR removes the api sub-module introduced by #169 in version v0.6.0. Having this module structure never brought the intended advantages and thus we switch back to one simple module. Please have a look at the linked issue if you are interested in more details.

Which issue(s) this PR fixes:
Fixes #243

Special notes for your reviewer:

Release note:

The sub-module `github.com/gardener/etcd-druid/api` has been removed. Please use `github.com/gardener/etcd-druid` instead if your module(s) depend on `etcd-druid`.

@timuthy timuthy requested a review from a team as a code owner October 21, 2021 13:42
@gardener-robot gardener-robot added area/dev-productivity Developer productivity related (how to improve development) kind/enhancement Enhancement, improvement, extension needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Oct 21, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 21, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 21, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 21, 2021
shreyas-s-rao
shreyas-s-rao approved these changes Oct 22, 2021
View reviewed changes
Copy link
Contributor

@shreyas-s-rao shreyas-s-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timuthy thanks for the PR! LGTM
Just a tiny detail: shouldn't the release note be breaking developer rather than breaking operator?

@timuthy
Copy link
Member Author

timuthy commented Oct 22, 2021

@timuthy thanks for the PR! LGTM Just a tiny detail: shouldn't the release note be breaking developer rather than breaking operator?

Absolutely, thanks for noticing 👍

@timuthy timuthy merged commit 071746e into gardener:master Oct 22, 2021
@timuthy timuthy deleted the enhancement.go-mod branch October 22, 2021 08:15
@timebertt timebertt mentioned this pull request Apr 5, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreyas-s-rao shreyas-s-rao shreyas-s-rao approved these changes

Assignees
No one assigned
Labels
area/dev-productivity Developer productivity related (how to improve development) kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] API module breaks components
5 participants
@timuthy @shreyas-s-rao @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot