Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] API submodule is pain #92

Open
timebertt opened this issue Apr 5, 2022 · 0 comments
Open

[BUG] API submodule is pain #92

timebertt opened this issue Apr 5, 2022 · 0 comments
Labels
area/dev-productivity Developer productivity related (how to improve development) kind/bug Bug lifecycle/rotten Nobody worked on this for 12 months (final aging stage)

Comments

@timebertt
Copy link
Member

/kind bug
/area dev-productivity

Describe the bug:

Similar to gardener/etcd-druid#243.

With gardener/gardener#5610 g/g is upgraded to hvpa-controller@v0.4.0 which introduces the /api submodule (#85).
When upgrading the g/g dependency to the latest release (v1.44.0) in provider-aws, I get:

github.com/gardener/gardener-extension-provider-aws/pkg/controller/bastion imports
	github.com/gardener/gardener/pkg/client/kubernetes imports
	github.com/gardener/hvpa-controller/api/v1alpha1: ambiguous import: found package github.com/gardener/hvpa-controller/api/v1alpha1 in multiple modules:
	github.com/gardener/hvpa-controller v0.3.1 (/Users/timebertt/go/pkg/mod/github.com/gardener/hvpa-controller@v0.3.1/api/v1alpha1)
	github.com/gardener/hvpa-controller/api v0.4.0 (/Users/timebertt/go/pkg/mod/github.com/gardener/hvpa-controller/api@v0.4.0/v1alpha1)

I can workaround this by adding replace directives as mentioned in gardener/etcd-druid#243

replace (
	github.com/gardener/hvpa-controller => github.com/gardener/hvpa-controller v0.4.0
	github.com/gardener/hvpa-controller/api => github.com/gardener/hvpa-controller/api v0.4.0
)

Note that this has to be added to every project that transiently depends on hvpa-controller.

Expected behaviour:

Projects having a transient dependency on hvpa-controller shouldn't need to add replace directives, which is prone to error, unneeded complexity and simply annoying.

Anything else we need to know?:

As said in gardener/etcd-druid#243 (comment), I would vote for removing the /api submodule again (ref gardener/etcd-druid#244) and never introduce it anywhere again to spare us the pain.

@timebertt timebertt added the kind/bug Bug label Apr 5, 2022
@gardener-robot gardener-robot added the area/dev-productivity Developer productivity related (how to improve development) label Apr 5, 2022
@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Oct 3, 2022
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dev-productivity Developer productivity related (how to improve development) kind/bug Bug lifecycle/rotten Nobody worked on this for 12 months (final aging stage)
Projects
None yet
Development

No branches or pull requests

2 participants