Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a dedicated module for api #169

Merged
merged 3 commits into from
May 10, 2021
Merged

Create a dedicated module for api #169

merged 3 commits into from
May 10, 2021

Conversation

amshuman-kr
Copy link
Collaborator

How to categorize this PR?

/area technical-debt
/kind enhancement
/priority normal

What this PR does / why we need it:

Reduces dependency hell.

Cherry-picked from @mvladev's PR #108 to work-around fixing conflicts in vendoring.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

A new module `github.com/gardener/etcd-druid/api` can be used to get the API definitions.

Switch to `github.com/gardener/etcd-druid-api` if you vendor only the API of etcd-druid.

Amshuman K R and others added 2 commits May 4, 2021 12:49
Create a dedicated module for api
e56a60e 
Reduces dependency hell

(cherry picked from commit 5d21e3e)
add additional tags
1bf5243 
(cherry picked from commit 082ca30)
@gardener-robot gardener-robot added the kind/enhancement Enhancement, improvement, extension label May 4, 2021
@gardener-robot
Copy link

@amshuman-kr Labels area/technical-debt, priority/normal do not exist.

@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels May 4, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 4, 2021
@amshuman-kr
Copy link
Collaborator Author

Will mark the PR ready after I fix the failing checks.

@gardener-robot gardener-robot added size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else and removed size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels May 4, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 4, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 4, 2021
@amshuman-kr amshuman-kr requested review from shreyas-s-rao, a team and abdasgupta and removed request for shreyas-s-rao and abdasgupta May 4, 2021 12:30
@amshuman-kr amshuman-kr marked this pull request as ready for review May 4, 2021 12:36
@amshuman-kr amshuman-kr changed the title [WIP] Create a dedicated module for api Create a dedicated module for api May 4, 2021
This was referenced May 4, 2021
Merged
Closed
abdasgupta
abdasgupta reviewed May 6, 2021
View reviewed changes
.ci/test Show resolved Hide resolved
abdasgupta
abdasgupta approved these changes May 10, 2021
View reviewed changes
Copy link
Contributor

@abdasgupta abdasgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amshuman-kr amshuman-kr merged commit 7e69d6c into gardener:master May 10, 2021
@amshuman-kr amshuman-kr deleted the add-api-module branch May 10, 2021 07:06
@amshuman-kr amshuman-kr mentioned this pull request May 19, 2021
Closed
@AxiomSamarth AxiomSamarth mentioned this pull request Jun 7, 2021
Closed
6 tasks
@AxiomSamarth AxiomSamarth mentioned this pull request Jul 26, 2021
Merged
This was referenced Oct 20, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdasgupta abdasgupta abdasgupta approved these changes

Assignees
No one assigned
Labels
kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review needs/second-opinion Needs second review by someone else size/l Size of pull request is large (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@amshuman-kr @gardener-robot @abdasgupta @gardener-robot-ci-2 @gardener-robot-ci-3