Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated github pages and Revendored MCM libraries @ v0.40.0 #21

Merged
merged 3 commits into from
Jul 28, 2021
Merged

Updated github pages and Revendored MCM libraries @ v0.40.0 #21

merged 3 commits into from
Jul 28, 2021

Conversation

AxiomSamarth
Copy link
Collaborator

@AxiomSamarth AxiomSamarth commented Jun 9, 2021 •
edited by prashanth26
Loading

What this PR does / why we need it:
This PR introduces documentation for Machine Controller Manager Provider GCP. The PR has two commits

  • Commit to create API module
  • Commit to introduce the docs and its setup

A quick look at the document can be taken here

Which issue(s) this PR fixes:
Fixes #20

Special notes for your reviewer:

Release note:

Added documentation

Revendored MCM libraries @ v0.40.0

@AxiomSamarth AxiomSamarth requested review from a team as code owners June 9, 2021 06:16
@gardener-robot gardener-robot added needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Jun 9, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 9, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 9, 2021
@AxiomSamarth
Copy link
Collaborator Author

Under the ./docs/docs folder, there is a markdown file on Machine-Controller-Manager. Later on, it shall be moved to the core MCM repository and referred from there as a single source for all out of tree providers.

@gardener-robot
Copy link

@prashanth26 You have pull request review open invite, please check

@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Jun 17, 2021
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Jun 24, 2021
prashanth26
prashanth26 reviewed Jul 1, 2021
View reviewed changes
api/v1alpha1/provider_spec.go Outdated Show resolved Hide resolved
api/v1alpha1/doc.go Outdated Show resolved Hide resolved
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 1, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 1, 2021
prashanth26
prashanth26 reviewed Jul 26, 2021
View reviewed changes
Copy link

@prashanth26 prashanth26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the late review.

api/v1alpha1/provider_spec.go Outdated Show resolved Hide resolved
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 28, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 28, 2021
prashanth26
prashanth26 approved these changes Jul 28, 2021
View reviewed changes
Copy link

@prashanth26 prashanth26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm can merged post @AxiomSamarth's test.

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Jul 28, 2021
@AxiomSamarth
Copy link
Collaborator Author

@prashanth26 I have tested this against a GCP cluster. Works well! Feel free to merge 😄

@prashanth26 prashanth26 changed the title GitHub pages Updated github pages and Revendored MCM libraries @ v0.40.0 Jul 28, 2021
@prashanth26 prashanth26 merged commit ae09641 into gardener:master Jul 28, 2021
@AxiomSamarth AxiomSamarth deleted the github-pages branch July 28, 2021 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prashanth26 prashanth26 prashanth26 approved these changes

Assignees
No one assigned
Labels
lifecycle/rotten Nobody worked on this for 12 months (final aging stage) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add documentation and create API module
6 participants
@AxiomSamarth @gardener-robot @prashanth26 @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3