This removes gambit-enumpoly from the default build and marks as expe… #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rimental. The implementation of gambit-enumpoly has a number of problems which have cumulated over the years, possibly related to building pelican on 64-bit systems. The roadmap calls for this method to be refactored heavily to separate out the concept of support enumeration from solution method, and to allow for different solution backends for given candidate supports. As such, for now, we are doing the following: 1. This method is now marked as "experimental" and removed from the build by default. 2. References to it in the graphical interface have been removed. (It was never the "recommended" solver so this has little effect unless someone was selecting it explicitly.)
tturocy
deleted the
392-enh-remove-enumpoly-references-from-graphical-interface-and-disable-build-by-default
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rimental.
The implementation of gambit-enumpoly has a number of problems which have cumulated over the years, possibly related to building pelican on 64-bit systems.
The roadmap calls for this method to be refactored heavily to separate out the concept of support enumeration from solution method, and to allow for different solution backends for given candidate supports.
As such, for now, we are doing the following: