Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Remove enumpoly references from graphical interface and disable build by default #392

Closed
Tracked by #376
tturocy opened this issue Oct 26, 2023 · 0 comments · Fixed by #397
Closed
Tracked by #376

ENH: Remove enumpoly references from graphical interface and disable build by default #392

tturocy opened this issue Oct 26, 2023 · 0 comments · Fixed by #397
Assignees
@tturocy
Milestone
gambit-16.1.0

Comments

@tturocy
Copy link
Member

tturocy commented Oct 26, 2023 •
edited
Loading

Overview

The implementation of enumpoly_solve is known to be unreliable - it produces unreliable output and also has a known issue with an infinite loop. It is also not building on Windows anyway.

Therefore, this is not a method that should be exposed at present to anything but extremely sophisticated users:

  • Remove enumpoly from the graphical interface entirely.
  • Change the default in the build configuration to not build the tool, and mark it explicitly as experimental.
@tturocy tturocy mentioned this issue Oct 26, 2023
Open
2 tasks
@tturocy tturocy changed the title Remove enumpoly references from graphical interface and disable build by default ENH: Remove enumpoly references from graphical interface and disable build by default Oct 26, 2023
@tturocy tturocy self-assigned this Oct 26, 2023
@tturocy tturocy added this to the gambit-16.1.0 milestone Oct 26, 2023
@tturocy tturocy linked a pull request Nov 2, 2023 that will close this issue
This removes gambit-enumpoly from the default build and marks as expe… #397
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tturocy tturocy

Labels
None yet
Projects
None yet
Milestone
gambit-16.1.0
Development

Successfully merging a pull request may close this issue.

This removes gambit-enumpoly from the default build and marks as expe… gambitproject/gambit
1 participant
@tturocy