Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Physics tests: Install and run Habitat-sim with Bullet physics #213

Merged
merged 19 commits into from
Oct 10, 2019

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Sep 16, 2019

Motivation and Context

Test installation of Bullet physics and habitat-sim with Bullet physics in circleCI.
Test python exposed dynamics with various physics implementations (only Bullet currently).

Leaving TODOs for later PR additions. We have no caching of dynamic state currently so I'm not querying or asserting anything about that yet. This PR is primarily to test bullet install, build with bullet, and run the simulator with dynamics.

How Has This Been Tested

Local (MacOS) and devfair (Ubuntu) pytest.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Testing

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Sep 16, 2019
@aclegg3 aclegg3 self-assigned this Sep 16, 2019
src/esp/gfx/Simulator.h Outdated Show resolved Hide resolved
@mosra mosra mentioned this pull request Sep 19, 2019
12 tasks
@aclegg3 aclegg3 marked this pull request as ready for review October 4, 2019 20:55
@aclegg3
Copy link
Contributor Author

aclegg3 commented Oct 4, 2019

I'd like to get this test (especially the build part) into master before the release. I'll write a separate PR to add assertions and additional tests once we have force/torque caching and more interesting time-stepping schemes.

@aclegg3 aclegg3 requested review from mathfac and msavva October 4, 2019 20:58
@aclegg3 aclegg3 changed the title [WIP] Physics tests: Bullet Physics tests: Install and run Habitat-sim with Bullet physics Oct 4, 2019
.circleci/config.yml Outdated Show resolved Hide resolved
tests/test_physics.py Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@mathfac mathfac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding physics testing. In future we need to expose physics enabling options to Python layer that we can test different configurations with pytest parameter sweeping.

.circleci/config.yml Outdated Show resolved Hide resolved
@aclegg3 aclegg3 merged commit 4102cf1 into master Oct 10, 2019
@aclegg3 aclegg3 deleted the physics_tests_bullet branch October 10, 2019 23:06
eundersander pushed a commit to eundersander/habitat-sim that referenced this pull request Aug 6, 2020
…ebookresearch#213)

* Eval on val and add an option to not take the checkpoints config
Ram81 pushed a commit to Ram81/habitat-web-sim that referenced this pull request Dec 10, 2020
…ookresearch#213)

* Download object test dataset and install Bullet physics with circleCI

* Introduced test_dynamics to model physics phenomena and assert expected simulation results
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants