Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on enableRenderableContext for www #28438

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

rickhanlonii
Copy link
Member

We can land for www now

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Feb 25, 2024
@react-sizebot
Copy link

Comparing: 239d06e...ecaac09

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 176.86 kB 176.86 kB = 55.13 kB 55.13 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 179.01 kB 179.01 kB = 55.77 kB 55.77 kB
facebook-www/ReactDOM-prod.classic.js = 594.00 kB 592.52 kB = 104.93 kB 104.72 kB
facebook-www/ReactDOM-prod.modern.js = 577.29 kB 576.30 kB = 101.95 kB 101.80 kB
facebook-www/ReactIs-dev.classic.js = 8.30 kB 7.70 kB = 1.97 kB 1.91 kB
facebook-www/ReactIs-dev.modern.js = 8.29 kB 7.70 kB = 1.97 kB 1.91 kB
facebook-www/ReactIs-prod.classic.js = 5.83 kB 5.21 kB = 1.36 kB 1.28 kB
facebook-www/ReactIs-prod.modern.js = 5.83 kB 5.21 kB = 1.36 kB 1.28 kB
test_utils/ReactAllWarnings.js Deleted 66.35 kB 0.00 kB Deleted 16.24 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/ReactDOMServer-dev.classic.js = 495.23 kB 494.18 kB = 100.66 kB 100.52 kB
facebook-www/ReactDOMServer-dev.modern.js = 492.65 kB 491.60 kB = 100.17 kB 100.05 kB
facebook-www/ReactDOMTesting-prod.modern.js = 593.97 kB 592.68 kB = 106.08 kB 105.89 kB
facebook-www/ReactDOMServerStreaming-dev.modern.js = 485.42 kB 484.37 kB = 98.55 kB 98.43 kB
facebook-www/ReactDOM-profiling.classic.js = 624.44 kB 622.96 kB = 109.49 kB 109.27 kB
facebook-www/ReactDOMTesting-prod.classic.js = 608.78 kB 607.30 kB = 108.62 kB 108.40 kB
facebook-www/ReactDOM-prod.classic.js = 594.00 kB 592.52 kB = 104.93 kB 104.72 kB
facebook-www/ReactART-prod.modern.js = 352.38 kB 351.39 kB = 59.92 kB 59.76 kB
facebook-www/ReactDOMServerStreaming-prod.modern.js = 208.22 kB 207.50 kB = 38.43 kB 38.30 kB
facebook-www/ReactDOMServer-prod.classic.js = 205.92 kB 205.17 kB = 37.35 kB 37.22 kB
facebook-www/ReactDOMServer-prod.modern.js = 204.36 kB 203.61 kB = 37.06 kB 36.90 kB
facebook-www/ReactART-prod.classic.js = 363.83 kB 362.35 kB = 61.92 kB 61.71 kB
facebook-www/ReactServer-dev.modern.js = 93.76 kB 93.27 kB = 22.23 kB 22.19 kB
facebook-www/JSXDEVRuntime-dev.classic.js = 50.68 kB 50.20 kB = 13.26 kB 13.22 kB
facebook-www/JSXDEVRuntime-dev.modern.js = 50.68 kB 50.20 kB = 13.26 kB 13.22 kB
facebook-www/React-profiling.classic.js = 21.01 kB 20.67 kB = 5.23 kB 5.19 kB
facebook-www/React-profiling.modern.js = 20.73 kB 20.39 kB = 5.17 kB 5.12 kB
facebook-www/React-prod.classic.js = 20.58 kB 20.24 kB = 5.15 kB 5.11 kB
facebook-www/React-prod.modern.js = 20.29 kB 19.95 kB = 5.08 kB 5.04 kB
facebook-www/React-dev.classic.js = 125.62 kB 123.44 kB = 29.91 kB 29.64 kB
facebook-www/React-dev.modern.js = 124.04 kB 121.85 kB = 29.52 kB 29.24 kB
facebook-www/ReactIs-dev.classic.js = 8.30 kB 7.70 kB = 1.97 kB 1.91 kB
facebook-www/ReactIs-dev.modern.js = 8.29 kB 7.70 kB = 1.97 kB 1.91 kB
facebook-www/ReactIs-prod.classic.js = 5.83 kB 5.21 kB = 1.36 kB 1.28 kB
facebook-www/ReactIs-prod.modern.js = 5.83 kB 5.21 kB = 1.36 kB 1.28 kB
test_utils/ReactAllWarnings.js Deleted 66.35 kB 0.00 kB Deleted 16.24 kB 0.00 kB

Generated by 🚫 dangerJS against ecaac09

@rickhanlonii
Copy link
Member Author

Tests pass, good to go

@rickhanlonii rickhanlonii merged commit 6c3b8db into facebook:main Feb 26, 2024
37 checks passed
@rickhanlonii rickhanlonii deleted the rh/context-flag branch February 26, 2024 15:08
github-actions bot pushed a commit that referenced this pull request Feb 26, 2024
We can land for www now

DiffTrain build for [6c3b8db](6c3b8db)
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
We can land for www now

DiffTrain build for commit 6c3b8db.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants