Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RN] Move unifiedSyncLane back to dynamic #28430

Merged
merged 1 commit into from
Feb 23, 2024
Merged

[RN] Move unifiedSyncLane back to dynamic #28430

merged 1 commit into from
Feb 23, 2024

Conversation

rickhanlonii
Copy link
Member

This surfaced a bug because it wasn't on everywhere, moving back to dynamic while we investigate the bug

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Feb 23, 2024
@sammy-SC sammy-SC self-requested a review February 23, 2024 15:02
@react-sizebot
Copy link

Comparing: aaa4acb...0fc7886

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 176.86 kB 176.86 kB = 55.14 kB 55.14 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 179.01 kB 179.01 kB = 55.78 kB 55.78 kB
facebook-www/ReactDOM-prod.classic.js = 592.40 kB 592.40 kB = 104.67 kB 104.67 kB
facebook-www/ReactDOM-prod.modern.js = 575.68 kB 575.68 kB = 101.66 kB 101.66 kB
test_utils/ReactAllWarnings.js Deleted 66.50 kB 0.00 kB Deleted 16.27 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 66.50 kB 0.00 kB Deleted 16.27 kB 0.00 kB

Generated by 🚫 dangerJS against 0fc7886

@sammy-SC sammy-SC merged commit 98b8359 into main Feb 23, 2024
37 checks passed
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
This surfaced a bug because it wasn't on everywhere, moving back to
dynamic while we investigate the bug
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
This surfaced a bug because it wasn't on everywhere, moving back to
dynamic while we investigate the bug

DiffTrain build for commit 98b8359.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants