Include server component names in the componentStack in DEV

[sebmarkbage]

I'm a bit ambivalent about this one because it's not the main strategy that I plan on pursuing. I plan on replacing most DEV-only specific stacks like console.error stacks with a new take on owner stacks and native stacks. The future owner stacks may or may not be exposed to error boundaries in DEV but if they are they'd be a new errorInfo property since they're owner based and not available in prod.

The use case in console.error mostly goes away in the future so this PR is mainly for error boundaries. It doesn't hurt to have it in there while I'm working on the better stacks though.

The componentStack property exposed to error boundaries is more like production behavior similar to new Error().stack (which even in DEV won't ever expose owner stacks because console.createTask doesn't affect these). I'm not sure it's worth adding server components in DEV (this PR) because then you have forked behavior between dev and prod.

However, since even in the future there won't be any other place to get the parent stack, maybe this can be useful information even if it's only dev. We could expose a third property on errorInfo that's DEV only and parent stack but including server components. That doesn't seem worth it over just having the stack differ in dev and prod.

I don't plan on adding line/column number to these particular stacks.

A follow up could be to add this to Fizz prerender too but only in DEV.

[react-sizebot]

Comparing: 66c8346...fe343f8

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	176.86 kB	176.86 kB	=	55.14 kB	55.14 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	179.01 kB	179.01 kB	=	55.78 kB	55.78 kB
facebook-www/ReactDOM-prod.classic.js	=	592.40 kB	592.40 kB	=	104.67 kB	104.67 kB
facebook-www/ReactDOM-prod.modern.js	=	575.68 kB	575.68 kB	=	101.66 kB	101.66 kB
test_utils/ReactAllWarnings.js	Deleted	66.59 kB	0.00 kB	Deleted	16.30 kB	0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
test_utils/ReactAllWarnings.js	Deleted	66.59 kB	0.00 kB	Deleted	16.30 kB	0.00 kB

Generated by 🚫 dangerJS against fe343f8

[gnoff]

Should the server component frames indicate they are not from the local environment?

[hoxyq]

Suggested change

// @reactVersion >=16.9

I think its fair to test this behaviour against react from main, not against react 17 or 18.

[sebmarkbage]

Should the server component frames indicate they are not from the local environment?

They have a (Server) suffix. It just doesn't show up because our stack normalization is very naive and strips out this (and adds at (**) where there would be no source line).

This is actually a little tricky in real life too though because for example error-stack-parser doesn't know how to parse these lines. However, that's already a problem with the built ins and host component frames. So using a regular off-the-shelf parser might not work - which was kind of the point that this should work. Maybe that's just inherent to naive parsers like that though and it's up to them to be a bit smarter.

I was considering using brackets instead but I'm not sure if that's used by any formats for other purposes. Where as (native) is a common pattern which this follows kind of.