Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: link to migration guide from Blogger to Docusaurus / remove blog.johnnyreilly.com Google Analytics tag from docs #8313

Merged
merged 3 commits into from
Nov 10, 2022

Conversation

johnnyreilly
Copy link
Contributor

@johnnyreilly johnnyreilly commented Nov 9, 2022

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

I'm really pleased that I migrated from Blogger to Docusaurus. But it wasn't straightforward. I want to make it easier for others to follow the same journey.

Also, it turns out people have been copy / pasting the example GTAG config from the docs which features my Google Analytics tag: https://docusaurus.io/docs/api/plugins/@docusaurus/plugin-google-gtag#ex-config

As a consequence, these websites are sending traffic to my Google Analytics property. My life is now spent sending PRs like this:

I'd like to make it less likely that others make the same mistake.

If you're curious how I realised: https://twitter.com/johnny_reilly/status/1590585546451333120

Test Plan

N/A

Test links

Deploy preview: https://deploy-preview-8313--docusaurus-2.netlify.app/community/resources#articles

Related issues/PRs

#8293

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 9, 2022
@netlify
Copy link

netlify bot commented Nov 9, 2022

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 021c95f
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/636ccf902002aa00075e9cd0
😎 Deploy Preview https://deploy-preview-8313--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 58 🟢 97 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 75 🟢 100 🟢 100 🟢 100 🟢 90 Report

@johnnyreilly johnnyreilly changed the title docs: link to migration guide from Blogger to Docusaurus docs: link to migration guide from Blogger to Docusaurus / remove blog.johnnyreilly.com Google Analytics tag from docs Nov 9, 2022
@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Nov 10, 2022
@slorber slorber merged commit dce4a68 into facebook:main Nov 10, 2022
@johnnyreilly johnnyreilly deleted the patch-1 branch November 10, 2022 11:25
@johnnyreilly
Copy link
Contributor Author

Thanks!

@slorber
Copy link
Collaborator

slorber commented Nov 10, 2022

You may want to edit older docs versions too to remove it everywhere 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants