Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove blog.johnnyreilly.com Google Analytics tag #1992

Merged
merged 2 commits into from
Nov 10, 2022

Conversation

johnnyreilly
Copy link
Contributor

What change does this PR introduce?

It will stop your docs site sending traffic data to Google Analytics against blog.johnnyreilly.com

Why was this change needed?

You probably don't want to send traffic to my Google analytics property.

Other information (Screenshots)

You can see me using it on my blog here: https://github.com/johnnyreilly/blog.johnnyreilly.com/blob/13e0433c32992592dfa59ff682c4443d8c62ef2c/blog-website/docusaurus.config.js#LL53C36-L53C36

Copy link
Contributor

@scopsy scopsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohhh so sorry about that, seems like it was wrongfully copy pasted :( Updated it to be the proper value. Thank you so much for bringing this up!

@scopsy scopsy merged commit dd4015e into novuhq:next Nov 10, 2022
@johnnyreilly
Copy link
Contributor Author

Haha - no worries!

@johnnyreilly
Copy link
Contributor Author

If you're curious how I realised: https://twitter.com/johnny_reilly/status/1590585546451333120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants