Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove blog.johnnyreilly.com Google Analytics tag from docs part 2 #8320

Merged
merged 1 commit into from
Nov 17, 2022

Conversation

johnnyreilly
Copy link
Contributor

@johnnyreilly johnnyreilly commented Nov 10, 2022

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Fixing up my mistaken committing of my gtag id to the Docusaurus repo. A follow on from #8313

Gosh my stats / SEO are such a mess now.

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 10, 2022
@johnnyreilly johnnyreilly changed the title Main remove blog.johnnyreilly.com Google Analytics tag from docs part 2 Nov 10, 2022
@netlify
Copy link

netlify bot commented Nov 10, 2022

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 921a57c
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/636d3d5da2da83000766041c
😎 Deploy Preview https://deploy-preview-8320--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟢 90 🟢 97 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 71 🟢 100 🟢 100 🟢 100 🟢 90 Report

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Nov 17, 2022
@slorber slorber changed the title remove blog.johnnyreilly.com Google Analytics tag from docs part 2 docs: remove blog.johnnyreilly.com Google Analytics tag from docs part 2 Nov 17, 2022
@slorber slorber merged commit 0309a6d into facebook:main Nov 17, 2022
@johnnyreilly
Copy link
Contributor Author

Thanks!

This was referenced Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants