Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Refactor Network Details to use Search Strategy #76928

Merged
merged 2 commits into from
Sep 9, 2020
Merged

[Security Solution] Refactor Network Details to use Search Strategy #76928

merged 2 commits into from
Sep 9, 2020

Conversation

patrykkopycinski
Copy link
Contributor

@patrykkopycinski patrykkopycinski commented Sep 8, 2020 •
edited
Loading

Summary

image

Checklist

@patrykkopycinski patrykkopycinski self-assigned this Sep 8, 2020
@patrykkopycinski patrykkopycinski marked this pull request as ready for review September 8, 2020 12:29
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

angorayc
angorayc approved these changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@angorayc angorayc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked out and ran, all looks fine! Thank you @patrykkopycinski nicely done 👍 👍 👍

@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
securitySolution 1973 +1 1972

async chunks size

id value diff baseline
securitySolution 10.0MB +44.2KB 10.0MB

page load bundle size

id value diff baseline
securitySolution 816.3KB -244.0B 816.6KB

distributable file count

id value diff baseline
default 45467 +8 45459

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@patrykkopycinski patrykkopycinski merged commit bfab380 into elastic:master Sep 9, 2020
@patrykkopycinski patrykkopycinski deleted the feat/network-details-search-strategy branch September 9, 2020 13:30
@patrykkopycinski patrykkopycinski mentioned this pull request Sep 9, 2020
Merged
patrykkopycinski added a commit to patrykkopycinski/kibana that referenced this pull request Sep 9, 2020
@patrykkopycinski @elasticmachine
[Security Solution] Refactor Network Details to use Search Strategy (e…
68cfc8c 
…lastic#76928)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Sep 9, 2020
@gmmorris
Merge branch 'master' into alerting-exempt-rbac
1ef7d8b 
* master: (68 commits)
  a11y tests on spaces home page including feature control  (elastic#76515)
  [ML] Transforms list: persist pagination through refresh interval (elastic#76786)
  [ML] Replace all use of date_histogram interval with fixed_interval (elastic#76876)
  [Timelion] Update timelion deprecation links (elastic#77008)
  [Security Solution] Refactor Network Details to use Search Strategy (elastic#76928)
  Upgrade elastic charts to 21.1.2 (elastic#76939)
  [Alerting][Connectors] Refactor Jira: Generic Implementation (phase one) (elastic#73778)
  [Snapshot & Restore] fix pre existing policy with no existing repository (elastic#76861)
  Update saved object management UI text (elastic#76826)
  [Form lib] Add validations prop to UseArray and expose "moveItem" handler (elastic#76949)
  [Logs UI] Use fields api in log stream (elastic#76919)
  [UI Metrics] Support multi-colon keys (elastic#76913)
  [APM] Script for creating functional test archive (elastic#76926)
  [ENDPOINT] First version of the trusted apps list. (elastic#76304)
  Correct field for rum page url (elastic#76916)
  [Security Solution] Fix redirect properly old SIEM App routes (elastic#76868)
  Bump http-proxy from 1.17.0 to 1.18.1 (elastic#76924)
  [RUM Dashboard] Visitor breakdown usability (elastic#76834)
  [Search] Add a new advanced setting searchTimeout (elastic#75728)
  [DOCS] Adds timelion deprecation to new visualize docs structure (elastic#76959)
  ...
patrykkopycinski added a commit that referenced this pull request Sep 9, 2020
@patrykkopycinski @elasticmachine
[Security Solution] Refactor Network Details to use Search Strategy (#…
55172e3 
…76928) (#77052)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This was referenced Sep 23, 2020
Merged
Merged
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angorayc angorayc angorayc approved these changes

Assignees

@patrykkopycinski patrykkopycinski

Labels
release_note:enhancement Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@patrykkopycinski @elasticmachine @kibanamachine @angorayc @MindyRS