Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Fix redirect properly old SIEM App routes #76868

Merged
merged 3 commits into from
Sep 9, 2020
Merged

[Security Solution] Fix redirect properly old SIEM App routes #76868

merged 3 commits into from
Sep 9, 2020

Conversation

patrykkopycinski
Copy link
Contributor

@patrykkopycinski patrykkopycinski commented Sep 7, 2020 •
edited
Loading

Summary

The current solution doesn't cover a case where the user accesses /app/siem/ url without a # at the end.
This PR adds support for that case and also some basic unit tests coverage for both cases.

Checklist

@patrykkopycinski patrykkopycinski added bug Fixes for quality problems that affect the customer experience release_note:fix Team:SIEM v8.0.0 v7.9.2 labels Sep 7, 2020
@patrykkopycinski patrykkopycinski self-assigned this Sep 7, 2020
@patrykkopycinski patrykkopycinski changed the title [Fix] Redirect properly old SIEM App routes [Security Solution] Fix redirect properly old SIEM App routes Sep 7, 2020
@patrykkopycinski patrykkopycinski marked this pull request as ready for review September 7, 2020 14:15
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

XavierM
XavierM approved these changes Sep 8, 2020
View reviewed changes
Copy link
Contributor

@XavierM XavierM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, can you put back the cypress test for URL compatibility here x-pack/plugins/security_solution/cypress/integration/url_compatibility.spec.ts

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

page load bundle size

id value diff baseline
securitySolution 813.6KB +767.0B 812.9KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@patrykkopycinski patrykkopycinski merged commit 7ba33ab into elastic:master Sep 9, 2020
@patrykkopycinski patrykkopycinski deleted the fix/old-siem-app-redirect branch September 9, 2020 09:13
This was referenced Sep 9, 2020
Merged
Merged
patrykkopycinski added a commit to patrykkopycinski/kibana that referenced this pull request Sep 9, 2020
@patrykkopycinski
[Security Solution] Fix redirect properly old SIEM App routes (elasti…
aa01c83 
…c#76868)
patrykkopycinski added a commit to patrykkopycinski/kibana that referenced this pull request Sep 9, 2020
@patrykkopycinski
[Security Solution] Fix redirect properly old SIEM App routes (elasti…
c80eda6 
…c#76868)
patrykkopycinski added a commit that referenced this pull request Sep 9, 2020
@patrykkopycinski
[Security Solution] Fix redirect properly old SIEM App routes (#76868) (
3c76124 
#77021)
patrykkopycinski added a commit that referenced this pull request Sep 9, 2020
@patrykkopycinski
[Security Solution] Fix redirect properly old SIEM App routes (#76868) (
2293f6b 
#77022)
gmmorris added a commit to gmmorris/kibana that referenced this pull request Sep 9, 2020
@gmmorris
Merge branch 'master' into alerting-exempt-rbac
1ef7d8b 
* master: (68 commits)
  a11y tests on spaces home page including feature control  (elastic#76515)
  [ML] Transforms list: persist pagination through refresh interval (elastic#76786)
  [ML] Replace all use of date_histogram interval with fixed_interval (elastic#76876)
  [Timelion] Update timelion deprecation links (elastic#77008)
  [Security Solution] Refactor Network Details to use Search Strategy (elastic#76928)
  Upgrade elastic charts to 21.1.2 (elastic#76939)
  [Alerting][Connectors] Refactor Jira: Generic Implementation (phase one) (elastic#73778)
  [Snapshot & Restore] fix pre existing policy with no existing repository (elastic#76861)
  Update saved object management UI text (elastic#76826)
  [Form lib] Add validations prop to UseArray and expose "moveItem" handler (elastic#76949)
  [Logs UI] Use fields api in log stream (elastic#76919)
  [UI Metrics] Support multi-colon keys (elastic#76913)
  [APM] Script for creating functional test archive (elastic#76926)
  [ENDPOINT] First version of the trusted apps list. (elastic#76304)
  Correct field for rum page url (elastic#76916)
  [Security Solution] Fix redirect properly old SIEM App routes (elastic#76868)
  Bump http-proxy from 1.17.0 to 1.18.1 (elastic#76924)
  [RUM Dashboard] Visitor breakdown usability (elastic#76834)
  [Search] Add a new advanced setting searchTimeout (elastic#75728)
  [DOCS] Adds timelion deprecation to new visualize docs structure (elastic#76959)
  ...
@ghost
Copy link

ghost commented Sep 16, 2020

HI @XavierM

We have validated this on "7.9.2 Snapshot" Elastic Stagging Cloud Environment and Found that mentioned changed are working Correctly.

Build Details:
Elastic Version : 7.9.2 SNAPSHOT

User is able Access to SecurtyApp successfully for both "/app/siem" & "/app/siem#/" url

  • /app/siem

image

  • /app/siem#/

image

Note: Deployed 7.8.0 Release Elastic Cloud Build for reference of old URL naming [i.e URL having SIEM ]
image

thanks !!

@patrykkopycinski
Copy link
Contributor Author

Thank you @karanbirsingh-qasource :)

@rylnd rylnd mentioned this pull request Oct 27, 2020
Closed
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XavierM XavierM XavierM approved these changes

Assignees

@patrykkopycinski patrykkopycinski

Labels
bug Fixes for quality problems that affect the customer experience release_note:fix Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.9.2 v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@patrykkopycinski @elasticmachine @kibanamachine @XavierM @MindyRS