Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct field for rum page url #76916

Merged
merged 2 commits into from
Sep 9, 2020
Merged

Correct field for rum page url #76916

merged 2 commits into from
Sep 9, 2020

Conversation

shahzad31
Copy link
Contributor

Summary

Fixes field for url to be displayed in filters

image

@shahzad31 shahzad31 requested a review from a team as a code owner September 8, 2020 09:59
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Sep 8, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@shahzad31 shahzad31 self-assigned this Sep 8, 2020
@shahzad31 shahzad31 added v7.10.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Sep 8, 2020
@formgeist
Copy link
Contributor

@shahzad31 Would you consider increasing the width of the popover in order to show more of the URL? Or even better, would it be possible to not show the entire URL, but simply the page name at the end of the full URL?

Screenshot 2020-09-08 at 12 08 17

This is the transactions list in APM

@shahzad31
Copy link
Contributor Author

shahzad31 commented Sep 8, 2020 •
edited
Loading

@shahzad31 Would you consider increasing the width of the popover in order to show more of the URL? Or even better, would it be possible to not show the entire URL, but simply the page name at the end of the full URL?

This is the transactions list in APM

@formgeist That sounds like a good idea, i just wanted to correct the field, don't want to modify this generic filter component

we already have a ticket to create a separate URL filter component which will support filter into es, i think we can cover this aspect in that ticket.

https://github.com/elastic/uptime-dev/issues/24

@formgeist
Copy link
Contributor

@shahzad31 Alright, just thought to mention it 👍

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
apm 4.9MB -12.0B 4.9MB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cauemarcondes
cauemarcondes approved these changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahzad31 shahzad31 merged commit a127766 into elastic:master Sep 9, 2020
@shahzad31 shahzad31 deleted the Correct-field-for-rum-page-url branch September 9, 2020 09:17
gmmorris added a commit to gmmorris/kibana that referenced this pull request Sep 9, 2020
@gmmorris
Merge branch 'master' into alerting-exempt-rbac
1ef7d8b 
* master: (68 commits)
  a11y tests on spaces home page including feature control  (elastic#76515)
  [ML] Transforms list: persist pagination through refresh interval (elastic#76786)
  [ML] Replace all use of date_histogram interval with fixed_interval (elastic#76876)
  [Timelion] Update timelion deprecation links (elastic#77008)
  [Security Solution] Refactor Network Details to use Search Strategy (elastic#76928)
  Upgrade elastic charts to 21.1.2 (elastic#76939)
  [Alerting][Connectors] Refactor Jira: Generic Implementation (phase one) (elastic#73778)
  [Snapshot & Restore] fix pre existing policy with no existing repository (elastic#76861)
  Update saved object management UI text (elastic#76826)
  [Form lib] Add validations prop to UseArray and expose "moveItem" handler (elastic#76949)
  [Logs UI] Use fields api in log stream (elastic#76919)
  [UI Metrics] Support multi-colon keys (elastic#76913)
  [APM] Script for creating functional test archive (elastic#76926)
  [ENDPOINT] First version of the trusted apps list. (elastic#76304)
  Correct field for rum page url (elastic#76916)
  [Security Solution] Fix redirect properly old SIEM App routes (elastic#76868)
  Bump http-proxy from 1.17.0 to 1.18.1 (elastic#76924)
  [RUM Dashboard] Visitor breakdown usability (elastic#76834)
  [Search] Add a new advanced setting searchTimeout (elastic#75728)
  [DOCS] Adds timelion deprecation to new visualize docs structure (elastic#76959)
  ...
shahzad31 added a commit to shahzad31/kibana that referenced this pull request Sep 10, 2020
@shahzad31
Correct field for rum page url (elastic#76916)
53e6b65
@shahzad31 shahzad31 mentioned this pull request Sep 10, 2020
Merged
shahzad31 added a commit that referenced this pull request Sep 10, 2020
@shahzad31
[7.x] Correct field for rum page url (#76916) (#77153)
cebb761
@sorenlouv sorenlouv removed the Team:APM All issues that need APM UI Team support label Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cauemarcondes cauemarcondes cauemarcondes approved these changes

Assignees

@shahzad31 shahzad31

Labels
release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shahzad31 @elasticmachine @formgeist @kibanamachine @cauemarcondes @sorenlouv