-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use URL escape for device command name and resource name #806
Conversation
8c1f421
to
309e93d
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #806 +/- ##
=======================================
Coverage 64.46% 64.46%
=======================================
Files 80 80
Lines 3079 3079
=======================================
Hits 1985 1985
Misses 905 905
Partials 189 189
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
0aa6460
to
abb2fde
Compare
5a01e9f
to
aa86b80
Compare
c429fcc
to
76b58ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should also be handled
path := path.Join(common.ApiEventRoute, serviceName, req.Event.ProfileName, req.Event.DeviceName, req.Event.SourceName) |
Remove the constraint of device command name and resource name, and use URL escape in client API. Close edgexfoundry#773 Signed-off-by: bruce <weichou1229@gmail.com>
Updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Remove the constraint of device command name and resource name, and use URL escape in client API.
Close #773
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-core-contracts/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
device-a/test:value
and put into the URL like /api/v2/device/name/Modbus-TCP-Device/device-a%2Ftest%3AvalueNew Dependency Instructions (If applicable)