New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Migrate Camera Management example to V3 #214

Merged

ajcasagrande merged 16 commits into edgexfoundry:minnesota-dev from lenny-goodell:cam-mgmt-v3

May 26, 2023

Member

lenny-goodell commented May 17, 2023

closes #194

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-examples/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

I have added unit tests for the new feature or bug fix (if not, why?) N/A
I have fully tested (add details below) this the new feature or bug fix (if not, why?)

Testing Instructions

run non-secure EdgeX stack
run make build
run ./app-camera-management -cp -d -o
Verify service starts without error.


          feat: Migrate Camera Management example to V3

645fc02

closes #194

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>

lenny-goodell requested review from ajcasagrande and presatish

May 17, 2023 21:51

ajcasagrande reviewed

View reviewed changes

Contributor

ajcasagrande left a comment

Code looks good. Going to test it out.

Contributor

ajcasagrande commented May 17, 2023

We have a helper command in the makefile that is failing. Probably needs to be updated.

make run-app                                                                                                2 ✘ 
EDGEX_SECURITY_SECRET_STORE=false ./app-camera-management
level=INFO ts=2023-05-17T22:14:37.510039985Z app=app-camera-management source=service.go:490 msg="Starting app-camera-management 0.0.0 "
level=INFO ts=2023-05-17T22:14:37.510110514Z app=app-camera-management source=config.go:640 msg="Loading configuration file from res/configuration.yaml"
level=INFO ts=2023-05-17T22:14:37.510323194Z app=app-camera-management source=config.go:226 msg="Private configuration loaded from file with 0 overrides applied"
level=ERROR ts=2023-05-17T22:14:37.510677004Z app=app-camera-management source=messaging.go:45 msg="MessageBus configuration not set or missing from service's GetBootstrap() implementation"
level=ERROR ts=2023-05-17T22:14:37.510690416Z app=app-camera-management source=factory.go:43 msg="App Service initialization failed: boostrapping failed"
error: unable to create new app service app-camera-management!
make: *** [Makefile:29: run-app] Error 255

Contributor

ajcasagrande commented May 17, 2023

Error with the config of evam url, or parsing:

level=ERROR ts=2023-05-17T22:18:26.229103635Z app=app-camera-management source=app.go:56 msg="Unable to query EVAM pipeline statuses. Is EVAM running? GET request to query EVAM pipeline statuses failed: fail to parse baseUrl -> parse \"http://localhost:8080pipelines/status\": invalid port \":8080pipelines\" after host"
level=ERROR ts=2023-05-17T22:18:26.233954785Z app=app-camera-management source=app.go:61 msg="no devices found: no devices registered yet for the device services device-onvif-camera or device-usb-camera"

Contributor

ajcasagrande commented May 17, 2023 •

edited

Loading

/home/anthony/go/pkg/mod/github.com/edgexfoundry/go-mod-core-contracts/v3@v3.0.0-dev.41/clients/http/utils/common.go

edgexfoundry/go-mod-core-contracts@1450102#diff-0140c618055f750aa9a4d186041e16ad2316f1d47bf2ee16f0810a0489a3c5faR78

Appears to have been broken via edgexfoundry/go-mod-core-contracts#806


          fix: Add the -cp -d flags to run-app target

ef24aa1

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>

Member Author

lenny-goodell commented May 17, 2023

We have a helper command in the makefile that is failing. Probably needs to be updated.

Yep, needed the -cp -d flags. Added


          fix: Add trailing slash to EVAM URL

d3d3966

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>

Member Author

lenny-goodell commented May 17, 2023

Error with the config of evam url, or parsing:

I think the config value now need a trailing slash. Added it.

presatish reviewed

View reviewed changes

Contributor

presatish left a comment •

edited

Loading

Need to update the copyrights of updated files. Rest of the code looks good.


          fix: Rework for leading slash for pipelines

3ac5a07

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>

ajcasagrande reviewed

View reviewed changes

application-services/custom/camera-management/appcamera/evam.go

               	if err != nil {
               		return err
               	}
-              	reqPath := path.Join("pipelines", info.Name, info.Version)
+              	reqPath := path.Join("/pipelines", info.Name, info.Version)

Contributor

ajcasagrande May 17, 2023

you have to fix in all of the calls.


          fix: address other instances of "pipelines"

7c564a1

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>

Contributor

vyshali-chitikeshi commented May 17, 2023

Not able to run edge-analytics and saample app successfully, attached log
edge_analytics_run_error.txt
sample_app_run_error.txt

Leonard Goodell added 2 commits

May 17, 2023 16:23


          fix: Chnage API veriosn in UI files

819b7d7

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>


          fix: Rebuild UI.

730aa8a

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>

Contributor

ajcasagrande commented May 17, 2023

@lenny-intel looks like readme links and examples needs to be updated from toml to yaml

Member Author

lenny-goodell commented May 17, 2023

looks like readme links and examples needs to be updated from toml to yaml

Yep, dang embedded TOML. On it.

Leonard Goodell and others added 2 commits

May 17, 2023 17:03


          fix: Update README and fix InsecureSecrets

0819bb5

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>


          fix: use new device-onvif-camera command names, and upgrade onvif lib

bf3de7a

Signed-off-by: Anthony Casagrande <anthony.j.casagrande@intel.com>

lenny-goodell linked an issue

that may be closed by this pull request

[Edgex 3.0] Upgrade App Service Examples (minnesota-dev branch) to V3 #194

Closed

17 tasks

presatish and others added 4 commits

May 18, 2023 16:29


          fix: updated copyright for updated files

2f9cdfe

Signed-off-by: preethi-satishcandra <preethi.satishchandra@intel.com>


          Merge remote-tracking branch 'edgex/minnesota-dev' into cam-mgmt-v3

9881c88

Signed-off-by: Anthony Casagrande <anthony.j.casagrande@intel.com>


          Merge branch 'cam-mgmt-v3' of github.com:lenny-intel/edgex-examples i…

98539f0

…nto cam-mgmt-v3

Signed-off-by: Anthony Casagrande <anthony.j.casagrande@intel.com>


          feat: add support for rtspauth credentials

b438419

Signed-off-by: Anthony Casagrande <anthony.j.casagrande@intel.com>

lenny-goodell commented

View reviewed changes

application-services/custom/camera-management/go.mod Outdated

-              	github.com/edgexfoundry/go-mod-bootstrap/v2 v2.3.0
-              	github.com/edgexfoundry/go-mod-core-contracts/v2 v2.3.0
+              	github.com/IOTechSystems/onvif v0.1.6
+              	github.com/edgexfoundry/app-functions-sdk-go/v3 v3.0.0-dev.66

Member Author

lenny-goodell May 25, 2023

@presatish , the SDK version can now be bumped to v3.0.0. Make tidy will bump the others


          build: update edgex go mods with v3 released versions

aef4935

Signed-off-by: preethi-satishcandra <preethi.satishchandra@intel.com>

ajcasagrande previously approved these changes

View reviewed changes


          fix: updated some configuration names

a2fd7dc

Signed-off-by: preethi-satishcandra <preethi.satishchandra@intel.com>

presatish dismissed ajcasagrande’s stale review via

a2fd7dc

May 26, 2023 21:59


          fix: removed some sample credentials

3e3f2f9

Signed-off-by: preethi-satishcandra <preethi.satishchandra@intel.com>

ajcasagrande approved these changes

View reviewed changes

ajcasagrande merged commit 11045f6 into edgexfoundry:minnesota-dev

lenny-goodell deleted the cam-mgmt-v3 branch

May 30, 2023 15:23

lenny-goodell mentioned this pull request

[Edgex 3.0] Upgrade App Service Examples (minnesota-dev branch) to V3 #194

Closed

17 tasks

lenny-goodell pushed a commit that referenced this pull request


          Merge minnesota-dev into main (#223)

ef42450

* feat: Helm chart updates for minnesota (#187)

List of changes:

- Brought README up-to-date
- Added support for authenticated pulls (to dockerhub)
- Added core-common-config microservice
- Brought command lines and environment variables up-to-date with EdgeX 3.0 docker-compose changes
- Added missing data volumes
- Created YAML values files to specify tip and releasee versions of containers
- Fixed bug in eKuiper volume initialization
- Repairs to ingress rules for port matching
- Documentation to obtain authentication JWT

Signed-off-by: Bryon Nevis <bryon.nevis@intel.com>

* feat: Upgrade all simple App Service examples to V3 (#193)

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>

* feat: Upgrade all advanced App Service examples to V3 (#195)

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>

* feat: Upgrade ibm-mqtt-export configurable example to V3 (#196)

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>

* refactor: Consume MakeItRun rename to Run (#198)

* feat: Upgrade ibm-mqtt-export configurable example to V3

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>

* refactor: Upgade cloud-event app service to use V3 (#200)

Signed-off-by: Marc-Philippe Fuller <marc-philippe.fuller@intel.com>

* fix: device-usb-camera to use the correct start up docker-entrypoint shell script (#207)

The device USB camera uses different executable like docker-entrypoint shell script for bootstrapper so update it for this case.

Signed-off-by: Jim Wang <yutsung.jim.wang@intel.com>

* refactor: Upgrade json-logic app service to use V3 (#206)

* refactor: Upgrade json-logic app service to use V3

closes: #194
Signed-off-by: Marc-Philippe Fuller <marc-philippe.fuller@intel.com>

* refactor: Upgrade influx-export to use V3 (#205)

* refactor: Upgrade influx-export to use V3

Signed-off-by: Marc-Philippe Fuller <marc-philippe.fuller@intel.com>

* refactor: Upgrade custom-trigger-nats-rpc to use V3 (#203)

Signed-off-by: Marc-Philippe Fuller <marc-philippe.fuller@intel.com>

* refactor: Upgrade fledge-export to use V3 (#204)

* refactor: Upgrade fledge-export to use V3

Signed-off-by: Marc-Philippe Fuller <marc-philippe.fuller@intel.com>

* refactor: Upgrade cloud-export-mqtt to use V3 (#201)

Signed-off-by: Marc-Philippe Fuller <marc-philippe.fuller@intel.com>

* refactor: Upgrade custom_trigger app service to use V3 (#202)

Signed-off-by: Marc-Philippe Fuller <marc-philippe.fuller@intel.com>

* refactor: Upgrade send-command to use V3 (#209)

* refactor: Upgrade send-command to use V3

Signed-off-by: Marc-Philippe Fuller <marc-philippe.fuller@intel.com>

* refactor: Upgrade secrets to use V3 (#208)

* refactor: Upgrade secrets to use V3

Signed-off-by: Marc-Philippe Fuller <marc-philippe.fuller@intel.com>

* fix: Address missed V3 migration of InsecureSecrets (#210)

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>

* feat: Remove random device and grove-c from example and update README (#212)

Closes: issue #211

Signed-off-by: Valina Li <valina.li@intel.com>

* feat: Update Camera Management example on minnesota-dev branch (#213)

* feat: Update Camera Managment exmaple on minnesota-dev branch

This is to sync minnesota-dev with latest on main prior to migrating it
to V3

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>

* fix: Change v2 API references to v3 (#215)

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>

* feat: Migrate Camera Management example to V3 (#214)

* feat: Migrate Camera Management example to V3

closes #194

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
Signed-off-by: Anthony Casagrande <anthony.j.casagrande@intel.com>
Signed-off-by: preethi-satishcandra <preethi.satishchandra@intel.com>
Co-authored-by: Anthony Casagrande <anthony.j.casagrande@intel.com>
Co-authored-by: preethi-satishcandra <preethi.satishchandra@intel.com>

* build: Update app service examples to released SDK (#218)

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>

* feat: Remove obsolete deployment templates (#219)

These were for the EdgeX ready program and never used/updated for new releases.

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>

* feat: Update to 3.0.0 images in helm values.yaml (#220)

Signed-off-by: Bryon Nevis <bryon.nevis@intel.com>

---------

Signed-off-by: Bryon Nevis <bryon.nevis@intel.com>
Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
Signed-off-by: Marc-Philippe Fuller <marc-philippe.fuller@intel.com>
Signed-off-by: Jim Wang <yutsung.jim.wang@intel.com>
Signed-off-by: Valina Li <valina.li@intel.com>
Signed-off-by: Anthony Casagrande <anthony.j.casagrande@intel.com>
Signed-off-by: preethi-satishcandra <preethi.satishchandra@intel.com>
Co-authored-by: Bryon Nevis <bryon.nevis@intel.com>
Co-authored-by: Marc-Philippe Fuller <marc-philippe.fuller@intel.com>
Co-authored-by: Jim Wang @ Intel <yutsung.jim.wang@intel.com>
Co-authored-by: Valina Li <valina.li@intel.com>
Co-authored-by: Anthony Casagrande <anthony.j.casagrande@intel.com>
Co-authored-by: preethi-satishcandra <preethi.satishchandra@intel.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet