Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Upgrade json-logic app service to use V3 #206

Merged
merged 2 commits into from
May 15, 2023

Conversation

marcpfuller
Copy link
Contributor

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-examples/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)

Testing Instructions

Start edgex with no-secty
run ./app-service -cp -o -dev
verify service starts up

closes: edgexfoundry#194
Signed-off-by: Marc-Philippe Fuller <marc-philippe.fuller@intel.com>
jim-wang-intel
jim-wang-intel previously approved these changes May 11, 2023
Signed-off-by: Marc-Philippe Fuller <marc-philippe.fuller@intel.com>
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit 2084fa7 into edgexfoundry:minnesota-dev May 15, 2023
@lenny-goodell lenny-goodell linked an issue May 18, 2023 that may be closed by this pull request
17 tasks
lenny-goodell pushed a commit that referenced this pull request May 31, 2023
* feat: Helm chart updates for minnesota (#187)

List of changes:

- Brought README up-to-date
- Added support for authenticated pulls (to dockerhub)
- Added core-common-config microservice
- Brought command lines and environment variables up-to-date with EdgeX 3.0 docker-compose changes
- Added missing data volumes
- Created YAML values files to specify tip and releasee versions of containers
- Fixed bug in eKuiper volume initialization
- Repairs to ingress rules for port matching
- Documentation to obtain authentication JWT

Signed-off-by: Bryon Nevis <bryon.nevis@intel.com>

* feat: Upgrade all simple App Service examples to V3 (#193)

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>

* feat: Upgrade all advanced App Service examples to V3 (#195)

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>

* feat: Upgrade ibm-mqtt-export configurable example to V3 (#196)

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>

* refactor: Consume MakeItRun rename to Run (#198)

* feat: Upgrade ibm-mqtt-export configurable example to V3

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>

* refactor: Upgade cloud-event app service to use V3 (#200)

Signed-off-by: Marc-Philippe Fuller <marc-philippe.fuller@intel.com>

* fix: device-usb-camera to use the correct start up docker-entrypoint shell script (#207)

The device USB camera uses different executable like docker-entrypoint shell script for bootstrapper so update it for this case.

Signed-off-by: Jim Wang <yutsung.jim.wang@intel.com>

* refactor: Upgrade json-logic app service to use V3 (#206)

* refactor: Upgrade json-logic app service to use V3

closes: #194
Signed-off-by: Marc-Philippe Fuller <marc-philippe.fuller@intel.com>

* refactor: Upgrade influx-export to use V3 (#205)

* refactor: Upgrade influx-export to use V3

Signed-off-by: Marc-Philippe Fuller <marc-philippe.fuller@intel.com>

* refactor: Upgrade custom-trigger-nats-rpc to use V3 (#203)

Signed-off-by: Marc-Philippe Fuller <marc-philippe.fuller@intel.com>

* refactor: Upgrade fledge-export to use V3 (#204)

* refactor: Upgrade fledge-export to use V3

Signed-off-by: Marc-Philippe Fuller <marc-philippe.fuller@intel.com>

* refactor: Upgrade cloud-export-mqtt to use V3 (#201)

Signed-off-by: Marc-Philippe Fuller <marc-philippe.fuller@intel.com>

* refactor: Upgrade custom_trigger app service to use V3 (#202)

Signed-off-by: Marc-Philippe Fuller <marc-philippe.fuller@intel.com>

* refactor: Upgrade send-command to use V3 (#209)

* refactor: Upgrade send-command to use V3

Signed-off-by: Marc-Philippe Fuller <marc-philippe.fuller@intel.com>

* refactor: Upgrade secrets to use V3 (#208)

* refactor: Upgrade secrets to use V3

Signed-off-by: Marc-Philippe Fuller <marc-philippe.fuller@intel.com>

* fix: Address missed V3 migration of InsecureSecrets (#210)

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>

* feat: Remove random device and grove-c from example and update README (#212)

Closes: issue #211

Signed-off-by: Valina Li <valina.li@intel.com>

* feat: Update Camera Management example on minnesota-dev branch (#213)

* feat: Update Camera Managment exmaple on minnesota-dev branch

This is to sync minnesota-dev with latest on main prior to migrating it
to V3

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>

* fix: Change v2 API references to v3 (#215)

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>

* feat: Migrate Camera Management example to V3 (#214)

* feat: Migrate Camera Management example to V3

closes #194

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
Signed-off-by: Anthony Casagrande <anthony.j.casagrande@intel.com>
Signed-off-by: preethi-satishcandra <preethi.satishchandra@intel.com>
Co-authored-by: Anthony Casagrande <anthony.j.casagrande@intel.com>
Co-authored-by: preethi-satishcandra <preethi.satishchandra@intel.com>

* build: Update app service examples to released SDK (#218)

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>

* feat: Remove obsolete deployment templates (#219)

These were for the EdgeX ready program and never used/updated for new releases.

Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>

* feat: Update to 3.0.0 images in helm values.yaml (#220)

Signed-off-by: Bryon Nevis <bryon.nevis@intel.com>

---------

Signed-off-by: Bryon Nevis <bryon.nevis@intel.com>
Signed-off-by: Leonard Goodell <leonard.goodell@intel.com>
Signed-off-by: Marc-Philippe Fuller <marc-philippe.fuller@intel.com>
Signed-off-by: Jim Wang <yutsung.jim.wang@intel.com>
Signed-off-by: Valina Li <valina.li@intel.com>
Signed-off-by: Anthony Casagrande <anthony.j.casagrande@intel.com>
Signed-off-by: preethi-satishcandra <preethi.satishchandra@intel.com>
Co-authored-by: Bryon Nevis <bryon.nevis@intel.com>
Co-authored-by: Marc-Philippe Fuller <marc-philippe.fuller@intel.com>
Co-authored-by: Jim Wang @ Intel <yutsung.jim.wang@intel.com>
Co-authored-by: Valina Li <valina.li@intel.com>
Co-authored-by: Anthony Casagrande <anthony.j.casagrande@intel.com>
Co-authored-by: preethi-satishcandra <preethi.satishchandra@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Edgex 3.0] Upgrade App Service Examples (minnesota-dev branch) to V3
3 participants