Remove assert from Http3Connection.SendAsync #74348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsFixes #74162. The assert in question was invalid, because we may close the connection gracefully without prior This PR also filters OperationAborted QuicExceptions from server-initiated streams since there is no need to call Abort when we already close the connection (and setting the _abortException in that case would be confusing).
|
rzikm
force-pushed
the
74162-Assert-failed-SystemNetHttpHttp3ConnectionSendAsync
branch
from
4963dff
to
59e06e8
Compare
|
/backport to release/7.0 |
|
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/2911235661 |
|
@rzikm backporting to release/7.0 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Patch format detection failed.
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
rzikm
added a commit
to rzikm/dotnet-runtime
that referenced
this pull request
Aug 23, 2022
* Remove assert in System.Net.Http.Http3Connection.SendAsync * Minor change
rzikm
added a commit
to rzikm/dotnet-runtime
that referenced
this pull request
Aug 24, 2022
carlossanlop
pushed a commit
that referenced
this pull request
Aug 24, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #74162.
The assert in question was invalid, because we may close the connection gracefully without prior
Http3Connection.Abortcall when responding to a GOAWAY.This PR also filters OperationAborted QuicExceptions from server-initiated streams since there is no need to call Abort when we already close the connection (and setting the _abortException in that case would be confusing).