-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove assert from Http3Connection.SendAsync #74348
Remove assert from Http3Connection.SendAsync #74348
Conversation
Tagging subscribers to this area: @dotnet/ncl Issue DetailsFixes #74162. The assert in question was invalid, because we may close the connection gracefully without prior This PR also filters OperationAborted QuicExceptions from server-initiated streams since there is no need to call Abort when we already close the connection (and setting the _abortException in that case would be confusing).
|
4963dff
to
59e06e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/backport to release/7.0 |
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/2911235661 |
@rzikm backporting to release/7.0 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Patch format detection failed.
Error: The process '/usr/bin/git' failed with exit code 128 Please backport manually! |
* Remove assert in System.Net.Http.Http3Connection.SendAsync * Minor change
Fixes #74162.
The assert in question was invalid, because we may close the connection gracefully without prior
Http3Connection.Abort
call when responding to a GOAWAY.This PR also filters OperationAborted QuicExceptions from server-initiated streams since there is no need to call Abort when we already close the connection (and setting the _abortException in that case would be confusing).