Skip to content

Commit

Permalink
Remove assert from Http3Connection.SendAsync (dotnet#74348)
Browse files Browse the repository at this point in the history
* Remove assert in System.Net.Http.Http3Connection.SendAsync

* Minor change
  • Loading branch information
rzikm committed Aug 23, 2022
1 parent 195178b commit fa66aab
Showing 1 changed file with 5 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ public async Task<HttpResponseMessage> SendAsync(HttpRequestMessage request, lon
catch (QuicException ex) when (ex.QuicError == QuicError.OperationAborted)
{
// This will happen if we aborted _connection somewhere and we have pending OpenOutboundStreamAsync call.
Debug.Assert(_abortException is not null);
// note that _abortException may be null if we closed the connection in response to a GOAWAY frame
throw new HttpRequestException(SR.net_http_client_execution_error, _abortException, RequestRetryType.RetryOnConnectionFailure);
}
finally
Expand Down Expand Up @@ -567,6 +567,10 @@ private async Task ProcessServerStreamAsync(QuicStream stream)
}
}
}
catch (QuicException ex) when (ex.QuicError == QuicError.OperationAborted)
{
// ignore the exception, we have already closed the connection
}
catch (Exception ex)
{
Abort(ex);
Expand Down

0 comments on commit fa66aab

Please sign in to comment.