Remove assert in System.Net.Http.Http3Connection.SendAsync

dotnet · Aug 22, 2022 · 59e06e8 · 59e06e8
1 parent 304ee17
commit 59e06e8
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http3Connection.cs b/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/Http3Connection.cs
@@ -240,7 +240,7 @@ public async Task<HttpResponseMessage> SendAsync(HttpRequestMessage request, lon
             catch (QuicException ex) when (ex.QuicError == QuicError.OperationAborted)
             {
                 // This will happen if we aborted _connection somewhere and we have pending OpenOutboundStreamAsync call.
-                Debug.Assert(_abortException is not null);
+                // note that _abortException may be null if we closed the connection in response to a GOAWAY frame
                 throw new HttpRequestException(SR.net_http_client_execution_error, _abortException, RequestRetryType.RetryOnConnectionFailure);
             }
             finally
@@ -569,7 +569,14 @@ private async Task ProcessServerStreamAsync(QuicStream stream)
             }
             catch (Exception ex)
             {
-                Abort(ex);
+                if (ex is QuicException qe && qe.QuicError == QuicError.OperationAborted)
+                {
+                    // ignore the exception, we have already closed the connection
+                }
+                else
+                {
+                    Abort(ex);
+                }
             }
             finally
             {