Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove node 12 Support #1388

Merged
merged 2 commits into from
Jul 23, 2022
Merged

Remove node 12 Support #1388

merged 2 commits into from
Jul 23, 2022

Conversation

b4s36t4
Copy link
Contributor

@b4s36t4 b4s36t4 commented Jul 12, 2022

PR of #1349


Closes #1349

@changeset-bot
Copy link

changeset-bot bot commented Jul 12, 2022

🦋 Changeset detected

Latest commit: cee49bf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 33 packages
Name Type
@graphql-yoga/common Major
graphql-yoga Major
@graphql-yoga/node Major
@graphql-yoga/render-graphiql Major
cloudflare-advanced Patch
cloudflare Patch
service-worker Patch
sveltekit Patch
graphql-config-example Patch
apollo-federation-gateway-with-yoga Patch
apollo-subgraph-with-yoga Patch
graphql-lambda Patch
defer-stream-example Patch
error-masking-example Patch
express-example Patch
fastify-modules-example Patch
fastify-example Patch
file-upload-nextjs-pothos Patch
file-upload-nexus Patch
file-upload Patch
example-generic-auth Patch
graphql-ws Patch
hackernews Patch
hello-world Patch
issue-template Patch
koa-example Patch
example-live-query Patch
nextjs-auth Patch
nextjs Patch
node-esm Patch
example-redis-pub-sub Patch
subscriptions-example Patch
hello-world-benchmark Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@saihaj saihaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Will hold off merging this until we branch out v2. Also thinking 🤔 how we should do docs for this change cc @n1ru4l

@n1ru4l n1ru4l changed the base branch from master to v3 July 13, 2022 08:36
Copy link
Collaborator

@n1ru4l n1ru4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @b4s36t4, I changed the target branch of this PR to the v3 branch. Could you please add a changeset as instructed in #1388 (comment)?

@ardatan ardatan merged commit eb72f4c into dotansimha:v3 Jul 23, 2022
ardatan added a commit that referenced this pull request Jul 23, 2022
* chore: remove node 12 checks in ci/cd, changed target to es2020

* Add changeset

Co-authored-by: Arda TANRIKULU <ardatanrikulu@gmail.com>
ardatan added a commit that referenced this pull request Jul 25, 2022
* chore: remove node 12 checks in ci/cd, changed target to es2020

* Add changeset

Co-authored-by: Arda TANRIKULU <ardatanrikulu@gmail.com>
ardatan added a commit that referenced this pull request Jul 25, 2022
* chore: remove node 12 checks in ci/cd, changed target to es2020

* Add changeset

Co-authored-by: Arda TANRIKULU <ardatanrikulu@gmail.com>
n1ru4l pushed a commit that referenced this pull request Jul 26, 2022
* chore: remove node 12 checks in ci/cd, changed target to es2020

* Add changeset

Co-authored-by: Arda TANRIKULU <ardatanrikulu@gmail.com>
ardatan added a commit that referenced this pull request Jul 27, 2022
* chore: remove node 12 checks in ci/cd, changed target to es2020

* Add changeset

Co-authored-by: Arda TANRIKULU <ardatanrikulu@gmail.com>
This was referenced Sep 21, 2022
@saihaj saihaj mentioned this pull request Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants