Skip to content

Commit

Permalink
Remove node 12 Support (#1388)
Browse files Browse the repository at this point in the history
* chore: remove node 12 checks in ci/cd, changed target to es2020

* Add changeset

Co-authored-by: Arda TANRIKULU <ardatanrikulu@gmail.com>
  • Loading branch information
b4s36t4 and ardatan committed Jul 25, 2022
1 parent 027fa34 commit 0aa653e
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 11 deletions.
9 changes: 9 additions & 0 deletions .changeset/bright-wasps-boil.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
'@graphql-yoga/common': major
'graphql-yoga': major
'@graphql-yoga/node': major
---

_Drop Node 12 Support_

GraphQL Yoga no longer supports Node 12 which is no longer an LTS version. GraphQL Yoga now needs Node 14 at least.
18 changes: 9 additions & 9 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,18 +4,18 @@ env:
on:
push:
branches:
- 'master'
- "master"
pull_request:
paths-ignore:
- 'website/**'
- "website/**"

jobs:
test-node:
name: Testing on Node ${{ matrix.node-version }}
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [12, 14, 16, 18]
node-version: [14, 16, 18]
fail-fast: false
steps:
- name: Checkout Repository
Expand All @@ -25,13 +25,13 @@ jobs:
uses: actions/setup-node@master
with:
node-version: ${{ matrix.node-version }}
cache: 'yarn'
cache: "yarn"

- name: Cache Node Modules
uses: actions/cache@v3
id: node-modules-cache-test-node
with:
path: '**/node_modules'
path: "**/node_modules"
key: ${{runner.os}}-${{ matrix.node-version }}-node-modules-${{hashFiles('yarn.lock')}}-${{hashFiles('patches/**/*')}}
restore-keys: |
${{runner.os}}-${{ matrix.node-version }}-node-modules-${{hashFiles('yarn.lock')}}-${{hashFiles('patches/**/*')}}
Expand All @@ -56,13 +56,13 @@ jobs:
uses: actions/setup-node@master
with:
node-version: 18
cache: 'yarn'
cache: "yarn"

- name: Cache Node Modules
uses: actions/cache@v3
id: node-modules-cache-test-esm
with:
path: '**/node_modules'
path: "**/node_modules"
key: ${{runner.os}}-18-node-modules-${{hashFiles('yarn.lock')}}
restore-keys: |
${{runner.os}}-18-node-modules-
Expand All @@ -88,7 +88,7 @@ jobs:
uses: actions/setup-node@master
with:
node-version: 18
cache: 'yarn'
cache: "yarn"

- name: Use Deno
uses: denoland/setup-deno@v1
Expand All @@ -97,7 +97,7 @@ jobs:
uses: actions/cache@v3
id: node-modules-cache-type-check
with:
path: '**/node_modules'
path: "**/node_modules"
key: ${{runner.os}}-18-node-modules-${{hashFiles('yarn.lock')}}
restore-keys: |
${{runner.os}}-18-node-modules-
Expand Down
3 changes: 1 addition & 2 deletions tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,12 @@
"compilerOptions": {
"baseUrl": ".",
"outDir": "dist",

"esModuleInterop": true,
"allowSyntheticDefaultImports": true,
"importHelpers": true,
"experimentalDecorators": true,
"module": "node16",
"target": "es2018",
"target": "ES2020",
"lib": ["es6", "esnext", "es2015", "dom", "webworker"],
"suppressImplicitAnyIndexErrors": true,
"moduleResolution": "node",
Expand Down

0 comments on commit 0aa653e

Please sign in to comment.