Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert "feat: helm requires bootstrap password (DET-10196)" #9345

Conversation

jesse-amano-hpe
Copy link
Contributor

Reverts #9274 due to remaining open questions about the desirability of the behavior.

@cla-bot cla-bot bot added the cla-signed label May 9, 2024
@jesse-amano-hpe jesse-amano-hpe marked this pull request as ready for review May 9, 2024 18:35
@determined-ci determined-ci added the documentation Improvements or additions to documentation label May 9, 2024
@determined-ci determined-ci requested a review from a team May 9, 2024 18:35
Copy link

netlify bot commented May 9, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 17bb131
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/663d1770295ef40008e858fd

@jesse-amano-hpe jesse-amano-hpe changed the title Revert "feat: helm requires bootstrap password (DET-10196)" fix: Revert "feat: helm requires bootstrap password (DET-10196)" May 9, 2024
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.16%. Comparing base (df0b7f9) to head (17bb131).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9345      +/-   ##
==========================================
- Coverage   45.16%   45.16%   -0.01%     
==========================================
  Files        1230     1230              
  Lines      154572   154572              
  Branches     2405     2405              
==========================================
- Hits        69816    69812       -4     
- Misses      84561    84565       +4     
  Partials      195      195              
Flag Coverage Δ
backend 41.81% <ø> (-0.01%) ⬇️
harness 64.07% <ø> (-0.01%) ⬇️
web 36.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@jesse-amano-hpe jesse-amano-hpe removed the request for review from NicholasBlaskey May 9, 2024 18:45
@jesse-amano-hpe jesse-amano-hpe merged commit 2445d39 into main May 9, 2024
77 of 102 checks passed
@jesse-amano-hpe jesse-amano-hpe deleted the revert-9274-jta/DET-10196/helm-requires-bootstrap-password branch May 9, 2024 18:45
jesse-amano-hpe added a commit that referenced this pull request May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants