fix: Revert "feat: helm requires bootstrap password (DET-10196)" (#9345)

determined-ai · May 9, 2024 · 2445d39 · 2445d39
1 parent df0b7f9
commit 2445d39
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 16 deletions.
diff --git a/docs/reference/deploy/helm-config-reference.rst b/docs/reference/deploy/helm-config-reference.rst
@@ -231,13 +231,10 @@
    any HTTP traffic. The default timeout is 300 (5 minutes).
 
 -  ``initialUserPassword``: Specifies a string containing the default password for the admin and
-   determined user accounts in a brand new deployment. This is required in order to prevent
-   potentially launching an unsecured cluster, but has no effect if the database has already been
-   created. (*Required*)
+   determined user accounts.
 
 -  ``defaultPassword``: (*Deprecated*) Specifies a string containing the default password for the
-   admin and determined user accounts in a brand new deployment. Use ``initialUserPassword``
-   instead.
+   admin and determined user accounts. Use ``initialUserPassword`` instead.
 
 -  ``logging``: Configures where trial logs are stored. This section takes the same shape as the
    logging configuration in the :ref:`cluster configuration <cluster-configuration>`, except that

diff --git a/docs/release-notes/helm-requires-initial-password.rst b/docs/release-notes/helm-requires-initial-password.rst
diff --git a/helm/charts/determined/templates/master-config.yaml b/helm/charts/determined/templates/master-config.yaml
@@ -56,7 +56,9 @@ stringData:
       {{- end }}
 
     security:
-      initial_user_password: {{ coalesce .Values.initialUserPassword .Values.defaultPassword | quote | required "An initial password for admin and determined users is required!" }}
+      {{- if .Values.initialUserPassword }}
+      initial_user_password: {{ coalesce .Values.initialUserPassword .Values.defaultPassword | quote }}
+      {{- end }}
       {{- if .Values.tlsSecret }}
       tls:
         cert: {{ include "determined.secretPath" . }}tls.crt

diff --git a/helm/charts/determined/values.yaml b/helm/charts/determined/values.yaml
@@ -346,10 +346,7 @@ resourcePools:
 # defaultComputeResourcePool: default
 
 ## Configure the initial user password for the cluster
-## Will be the password for both `admin` and `determined` default users at launch
-## This is required to ensure all launches have a password set, but has no effect
-## once a password is already set.
-# initialUserPassword:
+# initialUserPassword
 
 # additional_resource_managers:
 #   - resource_manager: