Some schema updates #286
Merged
Some schema updates #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 'master' of https://github.com/dandi/dandi-cli: Skip cache+symlink test on pre-3.8 Python on Windows Fix bug in test_memoize_path Run GitHub Actions tests daily BF: account for API returning metadata for dandiset now not nested within yet another key BF: ensure_datetime for mtime beore taking .timestamp BF: always install dateutil and use it by default for parsing ISO datetime strings
…dandiarchive So that it could be used also for ls or any other code which needs to go through the thing (dandiset, folder, assets()) in the archive. ATM we need to flip between Girder and DANDI API, so hat helper abstracts that away a bit more on top of having GirderCli and DandiAPIClient
Add dandi-publish to Docker Compose setup
It also adds listing of dandisets themselves for local paths (unless -r is used). No harmornization for records from URLs (API) is performed ATM
Co-authored-by: John T. Wodder II <jwodder@users.noreply.github.com>
RF: move+RF code for navigating dandi archive url from download into (new) dandiarchive module
Make YAMLFormatter sort keys
With RFings in master we can screw it up, and also web ui is fragile to wrong metadata records atm and there is no validation yet. Since we already have a header saying that all changes would be lost, I think the best course of action is just to not upload it at all!
Also harmonized returned value to always return the metadata record, otherwise how would Python user know what was registered?
ENH: provide original exception message while preparing LockingError exception
Co-authored-by: Yaroslav Halchenko <debian@onerussian.com>
Support h5py 3.0
To avoid maintaining two documentations, where each one coughs get out of sync. Closes dandi#278
DOC: strip away duplicate with the handbook information
Add workflow for publishing model schemata to dandi/schema
h5py 3.0 introduced breaking changes (see e.g. dandi#282) and hdmf yet to account for them. We better cache that version too to improve consistency of outputs etc
Add rudimentary duecredit support using zenodo's dandi-cli DOI
* upstream/master: (116 commits) ENH: basic duecredit support DOC: strip away duplicate with the handbook information Update CHANGELOG.md [skip ci] Tweak pubschemata commit message Adjust workflow path triggers Add comment to numpy API warning ignore setting Workflow for publishing model schemata to dandi/schema [dandi#275] Ignore numpy API warning Support h5py 3.0 Add healthchecks for the Postgres and minio Docker containers Include item path in "Multiple files found for item" message Copy files with `cp --reflink=auto` where supported Test the rest of keyring_lookup() More keyring_lookup() tests Test askyesno() Test that keyring backends specified with env vars take precedence over config files Test keyring_lookup() when backend is set via config file Test asking for an API key twice via input() Test keyring_lookup() when backend is set via env var Basic test of getting an API key via input() ...
updated just models
Fix publish-schemata workflow
change from disease to disorder
BF: add h5py.__version__ into the list of tokens for caching
|
i wanted to fix some tests here before merging this. |
* upstream/master: Update CHANGELOG.md [skip ci] change from disease to disorder Fix publish-schemata workflow updated just models BF: add h5py.__version__ into the list of tokens for caching
|
ok. I will then push just the merge of master you have made (f110465) into that PR so this diff starts to look sensible and we have conflict resolved in that PR |
Codecov Report
@@ Coverage Diff @@
## nwb2asset #286 +/- ##
=============================================
+ Coverage 82.29% 82.38% +0.08%
=============================================
Files 51 56 +5
Lines 4333 4735 +402
=============================================
+ Hits 3566 3901 +335
- Misses 767 834 +67
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
i'm going to merge this. i think this is ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.