Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dandi-publish to Docker Compose setup #232

Merged
merged 2 commits into from
Sep 8, 2020
Merged

Add dandi-publish to Docker Compose setup #232

merged 2 commits into from
Sep 8, 2020

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Sep 4, 2020

Closes #164.

@codecov
Copy link

codecov bot commented Sep 4, 2020

Codecov Report

Merging #232 into master will increase coverage by 0.40%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #232      +/-   ##
==========================================
+ Coverage   81.62%   82.03%   +0.40%     
==========================================
  Files          50       50              
  Lines        4168     4235      +67     
==========================================
+ Hits         3402     3474      +72     
+ Misses        766      761       -5     
Flag Coverage Δ
#unittests 82.03% <100.00%> (+0.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dandi/tests/fixtures.py 96.49% <100.00%> (+0.57%) ⬆️
dandi/support/tests/test_cache.py 97.93% <0.00%> (+4.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efdd6e2...2022f29. Read the comment docs.

@yarikoptic
Copy link
Member

Great! now we should be able to test /publish and thus downloads of versioned datasets etc. Thank you @jwodder !

@yarikoptic yarikoptic merged commit d091704 into master Sep 8, 2020
@yarikoptic yarikoptic deleted the gh-164b branch September 8, 2020 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "publish" (AKA API) service to testing docker compose setup
2 participants