Make assayType and anatomy default to None instead of []

dandi · Sep 9, 2020 · 33c7e53 · 33c7e53
1 parent ec32419
commit 33c7e53
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/dandi/metadata.py b/dandi/metadata.py
@@ -164,14 +164,14 @@ def extract_assay_type(metadata):
     if "assayType" in metadata:
         return [models.AssayType(identifier="assayType", name=metadata["assayType"])]
     else:
-        return []
+        return ...
 
 
 def extract_anatomy(metadata):
     if "anatomy" in metadata:
         return [models.Anatomy(identifier="anatomy", name=metadata["anatomy"])]
     else:
-        return []
+        return ...
 
 
 def extract_model(modelcls, metadata, **kwargs):

diff --git a/dandi/tests/test_metadata.py b/dandi/tests/test_metadata.py
@@ -127,8 +127,8 @@ def test_metadata2asset():
         wasDerivedFrom=[
             BioSample(
                 identifier="a1b2c3",
-                assayType=[],
-                anatomy=[],
+                assayType=None,
+                anatomy=None,
                 strain=None,
                 cellLine=None,
                 vendor=None,
@@ -203,8 +203,8 @@ def test_metadata2asset_simple1():
         wasDerivedFrom=[
             BioSample.unvalidated(
                 identifier=None,
-                assayType=[],
-                anatomy=[],
+                assayType=None,
+                anatomy=None,
                 strain=None,
                 cellLine=None,
                 vendor=None,