Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ADR 020 to use Any #6111

Merged
merged 17 commits into from
May 13, 2020
Merged

Update ADR 020 to use Any #6111

merged 17 commits into from
May 13, 2020

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented May 1, 2020 •
edited
Loading

ref: #6030, #6078

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@aaronc aaronc added the T: ADR An issue or PR relating to an architectural decision record label May 1, 2020
@aaronc aaronc marked this pull request as ready for review May 1, 2020 19:56
@aaronc aaronc added the R4R label May 1, 2020
@aaronc aaronc mentioned this pull request May 1, 2020
Closed
4 tasks
@clevinson clevinson added this to the v0.39 milestone May 1, 2020
webmaster128
webmaster128 reviewed May 2, 2020
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great suff! Makes sense overall. Glad we got the requirements straight and can be more specific now.

docs/architecture/adr-020-protobuf-transaction-encoding.md Show resolved Hide resolved
docs/architecture/adr-020-protobuf-transaction-encoding.md Outdated Show resolved Hide resolved
docs/architecture/adr-020-protobuf-transaction-encoding.md Outdated Show resolved Hide resolved
docs/architecture/adr-020-protobuf-transaction-encoding.md Show resolved Hide resolved
docs/architecture/adr-020-protobuf-transaction-encoding.md Outdated Show resolved Hide resolved
docs/architecture/adr-020-protobuf-transaction-encoding.md Outdated Show resolved Hide resolved
docs/architecture/adr-020-protobuf-transaction-encoding.md Outdated Show resolved Hide resolved
docs/architecture/adr-020-protobuf-transaction-encoding.md Outdated Show resolved Hide resolved
docs/architecture/adr-020-protobuf-transaction-encoding.md Show resolved Hide resolved
docs/architecture/adr-020-protobuf-transaction-encoding.md Show resolved Hide resolved
@aaronc @alexanderbez
Update docs/architecture/adr-020-protobuf-transaction-encoding.md
9eb543a 
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
@aaronc aaronc requested a review from clevinson as a code owner May 4, 2020 19:01
clevinson
clevinson reviewed May 6, 2020
View reviewed changes
Copy link
Contributor

@clevinson clevinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

High level makes sense to me. Provided some small type-o suggestions, but nothing blocking.

docs/architecture/adr-020-protobuf-transaction-encoding.md Outdated Show resolved Hide resolved
docs/architecture/adr-020-protobuf-transaction-encoding.md Outdated Show resolved Hide resolved
docs/architecture/adr-020-protobuf-transaction-encoding.md Show resolved Hide resolved
docs/architecture/adr-020-protobuf-transaction-encoding.md Outdated Show resolved Hide resolved
@aaronc aaronc mentioned this pull request May 8, 2020
Closed
@aaronc aaronc requested a review from jgimeno as a code owner May 13, 2020 15:55
alexanderbez
alexanderbez approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@aaronc aaronc mentioned this pull request May 13, 2020
Closed
27 tasks
aaronc added a commit that referenced this pull request May 13, 2020
@aaronc
Add Tx, SignDoc from #6111 to types/types.proto, refactor Tx -> TxI a…
6a1a345 
…nd Fee -> FeeI
@aaronc aaronc mentioned this pull request May 13, 2020
Merged
@aaronc aaronc requested a review from clevinson May 13, 2020 18:46
clevinson
clevinson approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@clevinson clevinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

@aaronc aaronc merged commit 32f82a9 into master May 13, 2020
@aaronc aaronc deleted the aaronc/6030-update-adr-020 branch May 13, 2020 19:33
@aaronc aaronc mentioned this pull request May 13, 2020
Closed
4 tasks
aaronc added a commit that referenced this pull request May 14, 2020
@aaronc
Merge PR #6214: Add Tx, SignDoc, etc. proto types from #6111
49ae880
@aaronc aaronc mentioned this pull request May 19, 2020
Merged
8 tasks
@aaronc aaronc mentioned this pull request Jun 16, 2020
Merged
8 tasks
@aaronc aaronc mentioned this pull request Aug 5, 2020
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 left review comments

@clevinson clevinson clevinson approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@alessio alessio Awaiting requested review from alessio

@fedekunze fedekunze Awaiting requested review from fedekunze

@hschoenburg hschoenburg Awaiting requested review from hschoenburg

@nylira nylira Awaiting requested review from nylira

@jgimeno jgimeno Awaiting requested review from jgimeno

Assignees
No one assigned
Labels
T: ADR An issue or PR relating to an architectural decision record
Projects
None yet
Milestone
v0.40 [Stargate]
Development

Successfully merging this pull request may close these issues.
4 participants
@aaronc @clevinson @webmaster128 @alexanderbez