Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tx, SignDoc, etc. proto types from 6111 #6214

Merged
merged 19 commits into from
May 14, 2020
Merged

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented May 13, 2020

ref: #6213, #6111

This PR:

It postpones actually implementing any new signing behavior to separate PRs.

@auto-comment
Copy link

auto-comment bot commented May 13, 2020

👋 Thanks for creating a PR!

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Thank you for your contribution to the Cosmos-SDK! 🚀

@aaronc aaronc changed the title Add Tx, SignDoc proto types from 6111 Add Tx, SignDoc, etc. proto types from 6111 May 13, 2020
@aaronc aaronc added T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). T: Proto Breaking Protobuf breaking changes: generally don't do this! labels May 13, 2020
@codecov
Copy link

codecov bot commented May 13, 2020

Codecov Report

Merging #6214 into master will not change coverage.
The diff coverage is 33.33%.

@@           Coverage Diff           @@
##           master    #6214   +/-   ##
=======================================
  Coverage   54.84%   54.84%           
=======================================
  Files         444      444           
  Lines       26771    26771           
=======================================
  Hits        14682    14682           
  Misses      11046    11046           
  Partials     1043     1043           

@aaronc aaronc mentioned this pull request May 13, 2020
27 tasks
@aaronc aaronc marked this pull request as ready for review May 13, 2020 19:34
@aaronc aaronc added the R4R label May 13, 2020
types/types.proto Outdated Show resolved Hide resolved
@aaronc aaronc removed T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). T: Proto Breaking Protobuf breaking changes: generally don't do this! labels May 14, 2020
tx/types/types.proto Outdated Show resolved Hide resolved
@aaronc
Copy link
Member Author

aaronc commented May 14, 2020

@alexanderbez I fixed the protocgen.sh script and moved to types/tx. Does that work?

@aaronc
Copy link
Member Author

aaronc commented May 14, 2020

Going to go ahead and merge this. There are a lot of pieces to get to

@aaronc aaronc merged commit 49ae880 into master May 14, 2020
@aaronc aaronc deleted the aaronc/6213-tx-proto branch May 14, 2020 19:27
@alexanderbez
Copy link
Contributor

Great work @aaronc 👏

@clevinson clevinson added this to the v0.39 milestone Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants