Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove proto oneof tx types #6256

Merged
merged 1 commit into from
May 19, 2020
Merged

Remove proto oneof tx types #6256

merged 1 commit into from
May 19, 2020

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented May 19, 2020

ref: #6111

Cleaning up the oneof transaction types in preparation for the Any migration


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@aaronc aaronc changed the title Remove oneof tx types Remove proto oneof tx types May 19, 2020
@aaronc aaronc marked this pull request as ready for review May 19, 2020 20:47
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alexanderbez alexanderbez added A:automerge Automatically merge PR once all prerequisites pass. R4R labels May 19, 2020
@aaronc aaronc added the T: Proto Breaking Protobuf breaking changes: generally don't do this! label May 19, 2020
@aaronc aaronc merged commit 9828071 into master May 19, 2020
@aaronc aaronc deleted the aaronc/remove-oneof-tx branch May 19, 2020 21:52
@aaronc aaronc mentioned this pull request May 20, 2020
8 tasks
@clevinson clevinson added this to the v0.39 milestone Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. T: Proto Breaking Protobuf breaking changes: generally don't do this!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants