-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Select/Enter frontend URL under "pereferences" #90
Conversation
@djay The other UI design i have for this is to move both fields into their own tab namely "Frontend" like in below screenshot or we can leave it as it is shown above. Alternative design: 2024-07-02.22-41-26.mp4 |
@MAX-786 I think I prefer the first design. I would change "Select Frontend URL" to "Frontend URL" and change the description to say something like "Changes the site to visit when in edit mode". I would also not have the toggle there and have the text input always visible with something like "Override URL" or "Custom URL" as the title and have the description mention that it overrides the selected URL if entered. |
@JeffersonBledsoe sure, I will update the titles
The purpose of toggle is that it shows you can either SELECT OR INPUT only (I also moved toggle at last so the ui won't move a lot) , we can also write this in description but having a toggle, IMHO i don't see any downside of it. It also saves us from having a scenario when user selected a url AND also typed in a url (valid/invalid) and then hit submit, then how we make a decision that which url should be picked. |
I think you are probably.right about the toggle making it more clear. |
Yepp, and as for now we do not have such widget in volto. I'll look into if it's feasible and fits in our timeline to develop our own widget like this. Till then IG we can go with this approach. |
@MAX-786 there is that widget in volto. it's use all over the place like subject/tags |
@djay Sorry but can you please share a link like in volto demo site, where this widget is used.. bcz i tried looking and couldn't find it 🥲 |
- Replace SET_SELECTED_BLOCK constant with SET_FRONTEND_PREVIEW_URL in actions.js and reducers.js - Adjust height calculation in styles.css for Iframe component - Remove unused code in utils/getSavedURLs.js - Update config.addonReducers in index.js to use frontendPreviewUrl reducer - Comment out Breadcrumbs component in App.jsx
@djay @JeffersonBledsoe Checkout above updated comment for latest design |
@MAX-786 make a new comment with a new video otherwise it's confusing what comments refer to? |
Current Design [Updated]:
2024-07-05.10-25-01.mp4 |
@MAX-786 not sure where the bit of gap at the top is coming from. But it's good enough. |
@djay I think having a separate section like "Managing multiple frontends" makes sense. |
@JeffersonBledsoe I am ready to merge this, if it looks good to you too? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MAX-786 You need to add the PersonalPreferences.original.jsx
for the shadow and to document in the code what changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me now :)
Fixes #89
You can,
Current Design [Updated]:
2024-07-05.10-25-01.online-video-cutter.com.mp4