Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I should see as much of the frontend as possible when editing esp on mobile (get rid of extra header) #56

Open
2 of 5 tasks
djay opened this issue Jun 18, 2024 · 4 comments

Comments

@djay
Copy link
Member

djay commented Jun 18, 2024

Problem

There are things about volto currently that make it hard to edit on mobile. But in general the volto and quanta UI is designed to be minimal so to make the UI works on mobile also. We should not get in the way of this by adding more things to the UI

Proposed solution

no additional toolbar or breadcrumbs

While it is nice having both the breadcrumbs and the frontend url on screen, in reality the frontend will most likely have it's own breadcrumbs so it's just wasting space. You can also ways use contents or the browser url bar to help see where you are. So I think going back to the quanta design of the frontend taking up 100% of the same and no new bar is better.

Quanta toolbar

Other issues around being able to add and delete blocks on mobile should largely be solved by the quanta toolbar.
But need to ensure this toolbar goes on the bottom on mobile during edit, and the quantatoolbar goes to the top

1 2 3
image image image
@MAX-786
Copy link
Member

MAX-786 commented Jun 18, 2024

I think we can put the ability to change the frontend in the persoanl preferences menu

this may not be our first requirement to do so but for now I think we can make it collapse-able, like at the top and have an arrow to expand it again.

@MAX-786
Copy link
Member

MAX-786 commented Jun 18, 2024

We should get rid of all the borders so iframe takes up the full center space

It is the same width as the Form.jsx of the Volto, meaning volto have this too, so are we okay with changing it? bcz then it would be very cluttering. I can give it a try and see how it looks.

@djay
Copy link
Member Author

djay commented Jun 19, 2024

You aren't comparing the same things. Form is just dealing with how volto renders content. A frontend is fully responible for rendering the whole page. If we want the IFrame to appear invisible and editing experience to be like volto then we need there to be nothing added to this middle section I think.

@djay djay changed the title change frontend on mobile I should be able to edit different frontends on mobile Jun 19, 2024
@djay djay changed the title I should be able to edit different frontends on mobile I should be able to edit different frontends on mobile (hide header/frontend url) Jun 19, 2024
@MAX-786
Copy link
Member

MAX-786 commented Jun 21, 2024

put in breadcrumbs and basic subnav into demo frontend

Done by MAX-786/hydra-nextjs-frontend#2

@djay djay changed the title I should be able to edit different frontends on mobile (hide header/frontend url) I should should see as much of the frontend as possible when editing esp on mobile (get rid of extra header) Jul 1, 2024
@MAX-786 MAX-786 changed the title I should should see as much of the frontend as possible when editing esp on mobile (get rid of extra header) I should see as much of the frontend as possible when editing esp on mobile (get rid of extra header) Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants