-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I should see as much of the frontend as possible when editing esp on mobile (get rid of extra header) #56
Comments
this may not be our first requirement to do so but for now I think we can make it collapse-able, like at the top and have an arrow to expand it again. |
It is the same width as the Form.jsx of the Volto, meaning volto have this too, so are we okay with changing it? bcz then it would be very cluttering. I can give it a try and see how it looks. |
You aren't comparing the same things. Form is just dealing with how volto renders content. A frontend is fully responible for rendering the whole page. If we want the IFrame to appear invisible and editing experience to be like volto then we need there to be nothing added to this middle section I think. |
Done by MAX-786/hydra-nextjs-frontend#2 |
Problem
There are things about volto currently that make it hard to edit on mobile. But in general the volto and quanta UI is designed to be minimal so to make the UI works on mobile also. We should not get in the way of this by adding more things to the UI
Proposed solution
no additional toolbar or breadcrumbs
While it is nice having both the breadcrumbs and the frontend url on screen, in reality the frontend will most likely have it's own breadcrumbs so it's just wasting space. You can also ways use contents or the browser url bar to help see where you are. So I think going back to the quanta design of the frontend taking up 100% of the same and no new bar is better.
change the env variable to it allows more than one preset frontend to make it easier to pick #62
Add "frontend" under "preferences" which lets you pick from one of many frontends pre-registered or type-in your own URL. #89
![image](https://private-user-images.githubusercontent.com/41700/340768694-c782f8a2-6f5e-4715-b48e-db281a8b45fa.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk5ODk0MzksIm5iZiI6MTcxOTk4OTEzOSwicGF0aCI6Ii80MTcwMC8zNDA3Njg2OTQtYzc4MmY4YTItNmY1ZS00NzE1LWI0OGUtZGIyODFhOGI0NWZhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzAzVDA2NDUzOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQwYzU4NGRkZmNlMzA3ZDkyMWZmYTI0NjMxMzYxYjE4YTk0NTEwYjJjYzVhM2UxYTZjNGE5MDE0ZjY4NTQzZDYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.wolT6V4PwzKxmh06HY2aMMq31K8js6HZE6FNrY6JnqA)
We should get rid of all the borders so iframe takes up the full center space
![image](https://private-user-images.githubusercontent.com/41700/340774565-98ed2814-da59-4f7d-a74d-6e8141e235b5.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk5ODk0MzksIm5iZiI6MTcxOTk4OTEzOSwicGF0aCI6Ii80MTcwMC8zNDA3NzQ1NjUtOThlZDI4MTQtZGE1OS00ZjdkLWE3NGQtNmU4MTQxZTIzNWI1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzAzVDA2NDUzOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTdlN2FlNDUxMTU4ZWI4MTk0ZWUyOGQ2MDc5ZjdjMTk3NGJkZWZmNTdhNDc5M2Y4Yjc5YjRmNzQ5MTUwYjM1YWQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.ODEfmFJwKQi03BTuGEx2IIldkEHZ7rfjuxTySYPsq9A)
remove the breadcrumbs
put in breadcrumbs and basic subnav into demo frontend
Quanta toolbar
Other issues around being able to add and delete blocks on mobile should largely be solved by the quanta toolbar.
But need to ensure this toolbar goes on the bottom on mobile during edit, and the quantatoolbar goes to the top
The text was updated successfully, but these errors were encountered: