Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL input bar usability issues #59

Open
JeffersonBledsoe opened this issue Jun 19, 2024 · 1 comment
Open

URL input bar usability issues #59

JeffersonBledsoe opened this issue Jun 19, 2024 · 1 comment

Comments

@JeffersonBledsoe
Copy link
Member

JeffersonBledsoe commented Jun 19, 2024

The input bar and button above the IFrame window, shown below, has a number of usability issues with it:

  • You can't press 'enter' on the

Suggested solution

should be all solved by #57 and moving to standard select component. Doesn't really need to track the current url anymore

Other solutions considered

from jeff

  • Split the bar into it's own component that accepts an onSubmit to better encapsulate logic and tidy up View.jsx
  • Add a label to the input (add an ID to the input, then use for="my-input-id"
  • Wrap the input and button in a form and move the onClick of the button to onSubmit on the form.
    • This handles things like pressing enter when the input is focused to submit the form
  • Use an uncontrolled input. No need to keep React state around to change the input value when the browser does this for us so simplifies the code.
@djay
Copy link
Member

djay commented Jun 19, 2024

@JeffersonBledsoe see #57. We get rid of the input and move it into the personal tools menu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants