-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue with scale height 65536
used as "flexible height"
#144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petschki
force-pushed
the
petschki-imagescales
branch
from
September 25, 2023 11:39
a629e5e
to
779d0e0
Compare
I added a test to verify the desired behavior. |
but also the test_create_new_hashkey_for_cropped_images is still failing and i think not without reason. |
petschki
force-pushed
the
petschki-imagescales
branch
from
September 26, 2023 13:43
7ad198d
to
e715b38
Compare
MrTango
approved these changes
Sep 26, 2023
This was referenced Sep 26, 2023
🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Plone 6 there are image scales with height
65536
in order to make the height calculated flexible when scaling down to the width. This is a problem in cropping editor, because there the flagcan_scale
checks if width and height of scaled image is larger than the original image.To make these scales croppable here's my solution proposal:
can_scale
only checks that the width of the scaled image is lower equal to the original width.65536
we calculate the height for the editor by the ratio of the original width/height.I'm not really happy with the hard coded pixel value though. I also thought about a checkbox in the settings to discard the maximum check for the editor and leave it up to the integrator to constrain the scales to the valid one.
feedback welcome...
see #130