Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product is not useable on Plone 6 #130

Closed
laulaz opened this issue Apr 7, 2023 · 3 comments
Closed

Product is not useable on Plone 6 #130

laulaz opened this issue Apr 7, 2023 · 3 comments
Labels

Comments

@laulaz
Copy link
Member

laulaz commented Apr 7, 2023

Beside #129, we have another big problem with OOTB Plone 6.

Most of the new image scales (introduced here) use 65536 as maximum height, see https://github.com/plone/plone.base/blob/38fe6d57faf9185f91b418a54bdff725ecb9f242/src/plone/base/interfaces/controlpanel.py#L1683-L1689

In plone.app.imagecropping, all of these scales are shown as not croppable, because the height can never be reached :

capture

The product is quite useless if you keep Plone scales ...

@laulaz laulaz added the bug label Apr 7, 2023
@MrTango
Copy link
Contributor

MrTango commented Sep 22, 2023

I had the same issue. But if you use a special scale, like a banner 1000x333px, which i wanted anyway it still works fine.
In the case of the very high numbers for height, we could calculate the default height from the width and aspect ratio and use this instead of complaining about the to high number.

@MrTango
Copy link
Contributor

MrTango commented Sep 22, 2023

something like:

if scale_height > orig_height:
    height = calculate_height_from_orig(image) 
else:
    height = scale_height

@petschki
Copy link
Member

this should be fixed with #144

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants