-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package updates #143
Package updates #143
Conversation
petschki
commented
Sep 25, 2023
- fix old imports
- upgrade resources
@krissik I've added |
I still get |
@@ -4,7 +4,7 @@ | |||
<records interface="plone.app.imagecropping.browser.settings.ISettings" | |||
remove="true" | |||
/> | |||
<records interface="Products.CMFPlone.interfaces.IBundleRegistry" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't we need an upgrade step here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, because the registries are saved with the prefix and this doesn't change
otherwise it works for me |
@krissik I've added the zcml include. |
i would say merge this one, the failure in main does not make any sense to me and rebuilding shows something completely different. |
Now it works for me - thanks! |