Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package updates #143

Merged
merged 11 commits into from
Sep 25, 2023
Merged

Package updates #143

merged 11 commits into from
Sep 25, 2023

Conversation

petschki
Copy link
Member

  • fix old imports
  • upgrade resources

@petschki
Copy link
Member Author

@krissik I've added Products.CMFCore to the dependencies as there are also import from there in the code. could you rebuild your installation with and try again?

@krissik
Copy link

krissik commented Sep 25, 2023

@krissik I've added Products.CMFCore to the dependencies as there are also import from there in the code. could you rebuild your installation with and try again?

I still get zope.interface.interfaces.ComponentLookupError: (<InterfaceClass zope.security.interfaces.IPermission>, 'cmf.ManagePortal')

@@ -4,7 +4,7 @@
<records interface="plone.app.imagecropping.browser.settings.ISettings"
remove="true"
/>
<records interface="Products.CMFPlone.interfaces.IBundleRegistry"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we need an upgrade step here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, because the registries are saved with the prefix and this doesn't change

@MrTango
Copy link
Contributor

MrTango commented Sep 25, 2023

otherwise it works for me

@petschki
Copy link
Member Author

Failing test is strange. It worked in the PR where implemented: #142 ... no clue why it's broken now. maybe @maethu ?

@petschki
Copy link
Member Author

I still get zope.interface.interfaces.ComponentLookupError: (<InterfaceClass zope.security.interfaces.IPermission>, 'cmf.ManagePortal')

@krissik I've added the zcml include.

@petschki
Copy link
Member Author

@MrTango I'd like to merge this when working for @krissik because I've another branch with the scaling fixes mentioned here #130 ... there I can look in detail into the hash key generation...

@MrTango
Copy link
Contributor

MrTango commented Sep 25, 2023

i would say merge this one, the failure in main does not make any sense to me and rebuilding shows something completely different.

@petschki petschki merged commit a2553b3 into master Sep 25, 2023
2 of 7 checks passed
@petschki petschki deleted the package-updates branch September 25, 2023 09:39
@krissik
Copy link

krissik commented Sep 25, 2023

Now it works for me - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants