Make sure the hash key changes after cropping an image. #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maethu
force-pushed
the
mle-force-new-hash-key
branch
from
e64c9b9
to
a8edc17
Compare
|
@petschki |
petschki
approved these changes
Sep 11, 2023
|
Somehow the test is broken after merging it into master. @maethu could you eventually take a look again? |
|
strange, the strings look exactly the same |
Merged
which is the problem, they shouldn't :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Even though an image gets changed via cropping it does maintain the same url. Which leads cache/proxy and browsers to potentially not download the new version of the cropped image.
Example:
After uploading a new image the url to the thumb scale is http://nohost/plone/testimage/@@images/image-128-fba13e5e2040bf30b80360aeaf2bb42f.png
After cropping the url is still http://nohost/plone/testimage/@@images/image-128-fba13e5e2040bf30b80360aeaf2bb42f.png
Explenation:
One part of the hash key in the default storage (IImageScaleStorage) is the _p_mtime (modification time if an object got changed during a transaction). This is basically the only parameter that we can change, without rewriting the storage, image factory and utilities.
Solution:
Mark the ImageBlobField as changed if a scale gets cropped.
This way we force the storage to generate a new has key for (all) the scales.