-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cropped scales are not working with brains (breaks Plone 6) #129
Comments
A bit more about this issue : cropping doesn't work (images are shown as not cropped) everywhere we try to use scales from brains in Plone ! Examples :
|
image_scales
metatada URLs
@laulaz I tries to solve it by reindexing the image scales upon crop of an image. But the problem there is, that the new hash key can only be calculated after the transaction was successful. This means the value in the catalog is always too old (from the prev. image). |
could you give the current master branch a try? we've fixed some reindexing and hash calculations here #144 |
Since plone/Products.CMFPlone#3521, image scales are stored in a catalog metadata.
This is very useful when using RESTAPI, but also to ensure that you have URLs that you can cache easily (if the image changes, the URLs with the hashes change too).
With cropped images, we have a problem : the catalog is not updated at all, and there is a difference between the annotation stored on the content and the
image_scales
metatada, resulting inNotFound
error.Example on Plone 6 :
We should change
p.a.imagecropping
to update theimage_scales
metatada according to cropped scales.Or do you see any drawback regarding this ? (@cekk maybe ?)
Maybe concerning Volto 😟
The text was updated successfully, but these errors were encountered: