Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin check-manifest to 0.41 on Python 2.7. #70

Merged
merged 1 commit into from
Nov 16, 2020
Merged

Pin check-manifest to 0.41 on Python 2.7. #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions plone-4.3.x.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ package-name =
show-picked-versions = true

[versions]
check-manifest = 0.41
# FIXME: This can be removed if Plone folks add the pin to Plone official cfgs.
# https://github.com/collective/buildout.plonetest/issues/25
zc.recipe.cmmi = 1.3.6
Expand Down
1 change: 1 addition & 0 deletions plone-4.x.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ package-name =
show-picked-versions = true

[versions]
check-manifest = 0.41
# https://github.com/collective/buildout.plonetest/issues/25
zc.recipe.cmmi = 1.3.6
zipp = <2.0.0
Expand Down
1 change: 1 addition & 0 deletions plone-5.0.x.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ package-name =
show-picked-versions = true

[versions]
check-manifest = 0.41
# FIXME: This can be removed if Plone folks add the pin to Plone official cfgs.
# https://github.com/collective/buildout.plonetest/issues/25
zc.recipe.cmmi = 1.3.6
Expand Down
1 change: 1 addition & 0 deletions plone-5.1.x.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ package-name =
show-picked-versions = true

[versions]
check-manifest = 0.41
# FIXME: This can be removed if Plone folks add the pin to Plone official cfgs.
# https://github.com/collective/buildout.plonetest/issues/25
zc.recipe.cmmi = 1.3.6
Expand Down
1 change: 1 addition & 0 deletions plone-5.2.x.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ plone-user = admin:admin
zc.recipe.cmmi = 1.3.6

[versions:python27]
check-manifest = 0.41
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't you want to pin this on buildout.coredev because it is not used there?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is pinned in coredev, only not in versions.cfg but in tests.cfg, as it is not used by core Plone. But we want to merge the versions from those two files at some point.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be good to put a FIXME comment with this information.

zipp = <2.0.0

[instance]
Expand Down
1 change: 1 addition & 0 deletions plone-5.x.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ show-picked-versions = true
zc.recipe.cmmi = 1.3.6

[versions:python27]
check-manifest = 0.41
zipp = <2.0.0

[instance]
Expand Down