Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pep517 to version that works with latest check-manifest. #686

Merged
merged 1 commit into from
Nov 7, 2020

Conversation

mauritsvanrees
Copy link
Sponsor Member

Updated check-manifest too.
It depends on 'build', added that too.
I ran into version conflicts with the easyform buildout, see collective/collective.easyform#253

(At some point we may want to publish the [versions] part of tests.cfg on dist.plone.org. Or merge it with versions.cfg in coredev. That would have prevented this, because in tests.cfg we already pinned check-manifest to a version that works with the older pep517.)

Updated check-manifest too.
It depends on 'build', added that too.
I ran into version conflicts with the easyform buildout, see collective/collective.easyform#253
@mauritsvanrees
Copy link
Sponsor Member Author

@jenkins-plone-org please run jobs

@jensens
Copy link
Sponsor Member

jensens commented Nov 7, 2020

+1 for merging both files

@mauritsvanrees mauritsvanrees merged commit 68e61a6 into 5.2 Nov 7, 2020
@mauritsvanrees mauritsvanrees deleted the maurits/check-manifest-build-pep517 branch November 7, 2020 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants