Pin check-manifest to 0.41 on Python 2.7. #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That is the last version that is compatible with 2.7. Also, 0.45+ pulls in newer version of packages like 'build' and 'pep517', and 'virtualenv'.
idgserpro
approved these changes
Nov 16, 2020
There was a problem hiding this comment.
This fix the error:
Error: The requirement ('distlib<1,>=0.3.1') is not allowed by your [versions] constraint (0.3.0)
I saw this in:
https://travis-ci.org/github/collective/sc.embedder/jobs/743219708#L1439
LGTM
| @@ -23,6 +23,7 @@ plone-user = admin:admin | |||
| zc.recipe.cmmi = 1.3.6 | |||
|
|
|||
| [versions:python27] | |||
| check-manifest = 0.41 | |||
There was a problem hiding this comment.
Didn't you want to pin this on buildout.coredev because it is not used there?
There was a problem hiding this comment.
It is pinned in coredev, only not in versions.cfg but in tests.cfg, as it is not used by core Plone. But we want to merge the versions from those two files at some point.
There was a problem hiding this comment.
It might be good to put a FIXME comment with this information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That is the last version that is compatible with 2.7.
Also, 0.45+ pulls in newer version of packages like 'build' and 'pep517', and 'virtualenv'.
For a sample error, see this easyform run on 5.1.