Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow numbers again #414

Merged
merged 2 commits into from
May 24, 2021
Merged

Allow numbers again #414

merged 2 commits into from
May 24, 2021

Commits on May 17, 2021

  1. Allow numbers again 

    Revert the changes in cnabio#257 which updated the spec to disallow
non-integer values. We misunderstood the canonical json spec and were
using a library that didn't support numbers.

I have an open PRs for cnab-go which tested out switching to a library
that support numbers in canonical json and it works great.

* cnabio/cnab-go#247
* cnabio/cnab-go#248

So now fields such as default, maximum, minimum, etc can use numbers
again!

Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
    @carolynvs
    carolynvs committed May 17, 2021
    Configuration menu
    Copy the full SHA
    10ffd86 View commit details
    Browse the repository at this point in the history

  2. Include integer and number in primitives list 

    Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
    @carolynvs
    carolynvs committed May 17, 2021
    Configuration menu
    Copy the full SHA
    bd2073f View commit details
    Browse the repository at this point in the history