Allow non-integer numbers in bundle.json #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolynvs
added a commit
to carolynvs/cnab-spec
that referenced
this pull request
May 17, 2021
Revert the changes in cnabio#257 which updated the spec to disallow non-integer values. We misunderstood the canonical json spec and were using a library that didn't support numbers. I have an open PRs for cnab-go which tested out switching to a library that support numbers in canonical json and it works great. * cnabio/cnab-go#247 * cnabio/cnab-go#248 So now fields such as default, maximum, minimum, etc can use numbers again! Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
carolynvs
added a commit
to cnabio/cnab-spec
that referenced
this pull request
May 24, 2021
* Allow numbers again Revert the changes in #257 which updated the spec to disallow non-integer values. We misunderstood the canonical json spec and were using a library that didn't support numbers. I have an open PRs for cnab-go which tested out switching to a library that support numbers in canonical json and it works great. * cnabio/cnab-go#247 * cnabio/cnab-go#248 So now fields such as default, maximum, minimum, etc can use numbers again! Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com> * Include integer and number in primitives list Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
carolynvs
force-pushed
the
enable-numbers
branch
2 times, most recently
from
3640b02
to
2227a77
Compare
|
#247 was merged, I think this only needs a rebase now? |
|
@radu-matei the tests won't pass until the spec is tagged. It is comparing my changes against the current spec, and so it's failing. Once I get Butcher's 👍 on the new release, then I can kick the build on this and it should be green. |
Now that we have switched to a canonical json library that supports non-integer numbers, I've updated the bundle.json definition to use float for: maximum, mimimum and multipleof. The tests now use non-integer numbers to validate that a bundle using values like 5.5 can be marshaled now. Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
|
/brig run |
Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
|
@radu-matei @vdice Okay, the spec change has been merged. This is ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have switched to a canonical json library that supports
non-integer numbers, I've updated the bundle.json definition to use
float for: maximum, mimimum and multipleof.
The tests now use non-integer numbers to validate that a bundle using
values like 5.5 can be marshaled now.
🛑 This relies on #247 and upstream changes to the schemas in cnab-spec. Once that is merged and the spec tagged with a patch release, I'll rebase.