Switch canonical json libraries #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolynvs
force-pushed
the
swap-canonical-jsons
branch
2 times, most recently
from
f2f94c2
to
eb5905c
Compare
vdice
approved these changes
May 7, 2021
There was a problem hiding this comment.
LGTM (pending consensus on cnabio/cnab-spec#413, which I'm in support of)
carolynvs
added a commit
to carolynvs/cnab-spec
that referenced
this pull request
May 17, 2021
Revert the changes in cnabio#257 which updated the spec to disallow non-integer values. We misunderstood the canonical json spec and were using a library that didn't support numbers. I have an open PRs for cnab-go which tested out switching to a library that support numbers in canonical json and it works great. * cnabio/cnab-go#247 * cnabio/cnab-go#248 So now fields such as default, maximum, minimum, etc can use numbers again! Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
carolynvs
added a commit
to cnabio/cnab-spec
that referenced
this pull request
May 24, 2021
* Allow numbers again Revert the changes in #257 which updated the spec to disallow non-integer values. We misunderstood the canonical json spec and were using a library that didn't support numbers. I have an open PRs for cnab-go which tested out switching to a library that support numbers in canonical json and it works great. * cnabio/cnab-go#247 * cnabio/cnab-go#248 So now fields such as default, maximum, minimum, etc can use numbers again! Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com> * Include integer and number in primitives list Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
radu-matei
approved these changes
May 24, 2021
The previous library didn't handle numbers as well and this other is endorsed by the canonical json spec. Signed-off-by: Carolyn Van Slyck <me@carolynvanslyck.com>
carolynvs
force-pushed
the
swap-canonical-jsons
branch
from
eb5905c
to
36b743c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous library didn't handle numbers as well and this other is endorsed by the canonical json spec.
I am holding off on using the number support until we agree to tweak the spec cnabio/cnab-spec#413