Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch canonical json libraries #131

Closed
carolynvs opened this issue Feb 5, 2023 · 0 comments · Fixed by #132
Closed

Switch canonical json libraries #131

carolynvs opened this issue Feb 5, 2023 · 0 comments · Fixed by #132
Assignees
@carolynvs

Comments

@carolynvs
Copy link
Collaborator

carolynvs commented Feb 5, 2023 •
edited

We switched canonical json libraries in the CNAB spec and cnab-go, but missed updating this repo at the same time which prevents pushing bundles that use numeric json types (e.g. the value 0.5 cannot be used in a bundle).

We should switch to using github.com/cyberphone/json-canonicalization and stop using the docker canonical json serializer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carolynvs carolynvs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use same canonical json library as cnab-go carolynvs/cnab-to-oci
1 participant
@carolynvs